Update saudi_arabia.py - Githubissues

vacanza / holidays

Generate and work with holidays in Python

https://pypi.org/project/holidays

MIT License

1.45k stars 460 forks source link

Update saudi_arabia.py #1879

Closed Saad-nvd closed 2 months ago

Saad-nvd commented 2 months ago

Added weekend = {FRI, SAT}

Proposed change

Updated weekend = {FRI, SAT}

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

arkid15r commented 2 months ago

Closing this as it's been taken care of here

Thank you, @Saad-nvd!

Saad-nvd commented 2 months ago

The below returns wrong weekend for Saudi Arabia: weekend = holidays.country_holidays('SA').weekend See attached snippet: SA Weekend

Saad-nvd commented 2 months ago

Please ignore my previous comment as I know the problem.