vacanza / holidays

Generate and work with holidays in Python
https://pypi.org/project/holidays
MIT License
1.45k stars 460 forks source link

"All Souls' Day" & "Christmas Eve" not showing up for Philippine holidays #1929

Closed AnomalousUnderdog closed 1 month ago

AnomalousUnderdog commented 1 month ago

Bug Report

Expected Behavior

November 2 for Philippines holidays.country_holidays("PH").get("2024-11-02") should return All Souls' Day. The Philippine government designates it as an "Additional Special (Non-Working) Day" nationwide.

Likewise, December 24 is designated Christmas Eve, again an Additional Special (Non-Working) Day.

Actual Behavior

holidays.country_holidays("PH").get("2024-11-02") does not return anything. "2024-11-02" in holidays.country_holidays("PH") returns False.

Steps to Reproduce the Problem

  1. type holidays.country_holidays("PH").get("2024-11-02")

Environment

Additional Context

PH gov page for holidays: https://www.officialgazette.gov.ph/nationwide-holidays/ (This page also has Dec 31 as "Last Day of the Year", my Google Calendar calls it "New Year's Eve", kinda silly excuse to make it a holiday but I guess I shouldn't complain) Wikipedia page of the holiday for reference: https://en.wikipedia.org/wiki/All_Souls%27_Day