Workalendar features into holidays package

vacanza / holidays

Open World Holidays Framework

https://pypi.org/project/holidays

MIT License

1.48k stars 467 forks source link

Workalendar features into holidays package #1930

Open ncooder opened 3 months ago

ncooder commented 3 months ago

As workalendar package is no longer actively maintained, I suggest to incorporate its functionality for calculating working days into this package. This integration would provide users with a reliable and up-to-date solution for working day calculations.

arkid15r commented 3 months ago

As workalendar package is no longer actively maintained, I suggest to incorporate its functionality for calculating working days into this package. This integration would provide users with a reliable and up-to-date solution for working day calculations.

Any examples of the suggested functionality?

It'd be really helpful if you used the issue template. Thank you!

ncooder commented 3 months ago

As workalendar package is no longer actively maintained, I suggest to incorporate its functionality for calculating working days into this package. This integration would provide users with a reliable and up-to-date solution for working day calculations.

Any examples of the suggested functionality?

It'd be really helpful if you used the issue template. Thank you!

Especially calculating working days count. I believe that many of those features that are implemented in the workalendar can be transferred to the holidays package, such as:

weekend days for ISO country codes,
validation of ISO country codes with exact dates of future holidays (as a base). The point is that several issues in this package are already solved and can be easily used in the holidays package.

PPsyrius commented 2 months ago

So, to recap, these functions - right? @ncooder

.is_working_day(date) - check if neither weekend or holidays.
.add_working_days(date, days) - get the next nth day that's neither weekend or holidays.
.get_working_days_delta(date1, date2) - get the amount of workdays between the two dates that's neither weekend or holidays.
.export_to_ical(period) - exports holidays to iCal file format.

I'm pretty sure other syntactic sugars listed in advance features are already supported by python-holidays natively.

ncooder commented 2 months ago

@PPsyrius Yes, exactly. Thank you for this list.