Add New Zealand Subdivision Aliases (`EN`, `MI`, HASC)

PPsyrius commented 1 month ago

Proposed change

Migrates deprecated New Zealand subdivisions to a new subdivision aliases system, and Maori names (ISO) and HASC 2-letter codes were added as optional aliases.

The "South Canterbury" subregion is undeprecated as they're still in active use as Regional Holiday Anniversaries: https://www.govt.nz/browse/work/public-holidays-and-work/public-holidays-and-anniversary-dates/ . As the New Zealand government never gave these territories any acronyms, the full name is getting used here. I'm not sure about its name, though; maybe a possible rename to "Canterbury (South)" to match the source above?

"Waitangi" is removed from the _deprecated_subdivisions list altogether as they're mistakenly added there in the first place in #608. It isn't remapped into any other subdivision at the moment, so they should be safe to remove here.

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/pin/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6ec8d56) to head (ff67f29). Report is 2 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1952 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 188 188 Lines 11419 11400 -19 Branches 1795 1785 -10 ========================================= - Hits 11419 11400 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PPsyrius commented 1 month ago

This should hopefully be the last PR for "_deprecated_subdivisions migration to subdivisions_aliases" right now unless I'm mistaken. 🙏