Add Dominica holidays - Githubissues

PPsyrius commented 1 month ago

Proposed change

Add Dominica holidays.

Resolves #1172 .

[!NOTE] While Dominica's Public Holidays Act itself states that Labour Day falls on May, 1st, this has been de facto been observed on 1st Monday of May since at least 2010 continuously to the present (2024). As we cannot find the relevant amendments that caused that, we'll assume that the change started in 2010 for our current implementation.

Type of change

[x] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/pin/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e9c1b3d) to head (1d1bfd8). Report is 1 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1956 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 187 188 +1 Lines 11382 11421 +39 Branches 1792 1794 +2 ========================================= + Hits 11382 11421 +39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.