Update Singapore holidays: add `en_SG`, `en_US`, `th` localization

PPsyrius commented 6 days ago

Proposed change

Adds English (en_SG, en_US) and Thai (th) localization for Singapore holidays.

I tried to standardize en_US localization to the common Islamic holiday terms used in this library, i.e. Eid al-Fitr instead of Hari Raya Puasa used in en_SG, so any feedback here would be appreciated.

[!NOTE] Thai Public Broadcasting Service (Thai PBS) is used as the primary source for Islamic holidays naming over Thai Wikipedia ones i.e. อีฎิ้ลฟิตริ instead of อีดิลฟิฏร์

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/pin/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (112b043) to head (f93eb6c). Report is 1 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #2031 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 189 189 Lines 11479 11483 +4 Branches 1795 1795 ========================================= + Hits 11479 11483 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KJhellico commented 6 days ago

I tried to standardize en_US localization to the common Islamic holiday terms used in this library, i.e. Eid al-Fitr instead of Hari Raya Puasa used in en_SG, so any feedback here would be appreciated.

I completely agree with en_US standardization! (As I understand, these names, "Hari Raya Puasa" and "Hari Raya Haji", are in fact Malay)