search

vacanza / holidays

World Holidays Framework
https://pypi.org/project/holidays
MIT License
1.48k stars 467 forks source link

Questions regarding Brazilian holidays #2128

Open pedrovidal opened 1 day ago

pedrovidal commented 1 day ago

Hello,

I have some questions regarding Brazilian holidays:

  1. In Brazil, there are a few important dates that aren't currently listed, like mother's day (second sunday in may, same as USA), father's day (second sunday in august), easter (as mentioned in https://github.com/vacanza/holidays/issues/1703) and valentine's day (celebrated on june 12th). Those are not considered holidays but are celebrated, so would it be possible to add them as UNOFFICIAL? Father's day and mother's day are also listed here;
  2. As mentioned in https://github.com/vacanza/holidays/issues/292, ash wednesday is a half-day holiday. Since the HALF_DAY category has been created, could this change be implemented?
  3. From my experience, christmas eve and new year's eve are not considered holidays. Some companies consider it a half-day, but that's not guaranteed. Not sure if they should remain as OPTIONAL or be considered as HALF_DAY or UNOFFICIAL instead.

If any of those changes sound good, I’d be happy to help implement them!

Thanks!

PPsyrius commented 22 hours ago

  1. I would say the difference between WORKDAY and UNOFFICIAL is that the former is officially observed by the government via an act/decree but not declared as a holiday, while UNOFFICIAL is commonly observed by the people there but didn't have official recognition status or events held for it by the state. In this case, Mother's Day would be considered WORKDAY instead since it was officially signed into a decree by Getúlio Vargas in 1932 while Valentine's Day would be UNOFFICIAL

  2. Exactly as you suggested here.

  3. It should remain OPTIONAL IMO if they're usually added as company holidays.