Migrate Japan holidays to ObservedHolidayBase - Githubissues

vacanza / python-holidays

Generate and work with holidays in Python

https://pypi.org/project/holidays

MIT License

1.39k stars 447 forks source link

Migrate Japan holidays to ObservedHolidayBase #1810

Closed KJhellico closed 1 month ago

KJhellico commented 1 month ago

Proposed change

Migrate Japan holidays to ObservedHolidayBase.

Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9306627064

Details

19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 9291123942:	0.0%
Covered Lines:	11301
Relevant Lines:	11301

💛 - Coveralls

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud