Refactor Aruba/Curaçao as NL subdivision

vacanza / python-holidays

Generate and work with holidays in Python

https://pypi.org/project/holidays

MIT License

1.45k stars 459 forks source link

Refactor Aruba/Curaçao as NL subdivision #1852

Open arkid15r opened 3 months ago

arkid15r commented 3 months ago

Feature Request

Description

Make sure Aruba and Curaçao are available as a subdiv of Netherlands (based on https://www.iso.org/obp/ui/en/#iso:code:3166:AW and https://www.iso.org/obp/ui/en/#iso:code:3166:CW).

Related Issues

N/A

Proposed Solution

Move the AW and CW holidays logic to NL class.
Refactor Aruba logic to be based on NL's subdiv AW
Refactor Curaçao logic to be based on NL's subdiv CW

Additional context

N/A

KJhellico commented 3 months ago

It seems logical to do the same for Aruba.

arkid15r commented 3 months ago

It seems logical to do the same for Aruba.

Absolutely! I've updated the issue. Thanks!

PPsyrius commented 1 month ago

Quick question here: Isle of Man, Jersey, and Guernsey were previously callable as Great Britain subdivisions before 2007: https://en.wikipedia.org/wiki/ISO_3166-2:GB as GB-IOM, GB-GSY, and GB-JSY respectively. Should these entities get the same treatment, too?

Ideally, we should have ways to call up the appropriate holiday codes rather than folding them into the main entities. That would be great here.