search

vacanza / python-holidays

Generate and work with holidays in Python
https://pypi.org/project/holidays
MIT License
1.43k stars 457 forks source link

Tree planting day in South Korea #788

Closed Inundata closed 1 year ago

Inundata commented 1 year ago

I found that there is an error about the tree-planting day.

This day was ruled out from the holiday after 2006.

However, the package still returns this day as a holiday on 2006-4-5 and 2007-4-5.

https://glaw.scourt.go.kr/wsjo/lawod/sjo190.do?contId=1680822#1668387535738 ← This is the Decree on which it is based.

Translating the Decree shortly, the Tree planting day and the Constitution day would be ruled out after 2006 and 2008, respectively.

dr-prodigy commented 1 year ago

@Inundata does #791 fix it? Pls let us know, thx

arkid15r commented 1 year ago

Fixed in https://github.com/dr-prodigy/python-holidays/pull/791/, closing this. @Inundata thanks for reporting the issue!