search

vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
249 stars 54 forks source link

test(flaky): Log checkExpiring failure #1018

Closed AlejandroCabeza closed 7 months ago

AlejandroCabeza commented 8 months ago

Changed check to assert to leverage the capability of returning a message on failure, as check does not have that capability (that I know of) and using logs (e.g.: error, debug) was not working for me.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eb0890c) 83.18% compared to head (77519a7) 83.18%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1018/graphs/tree.svg?width=650&height=150&src=pr&token=UR5JRQ249W&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1018?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) ```diff @@ Coverage Diff @@ ## unstable #1018 +/- ## ========================================= Coverage 83.18% 83.18% ========================================= Files 91 91 Lines 15349 15349 ========================================= Hits 12768 12768 Misses 2581 2581 ```