search

vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
251 stars 55 forks source link

increase tolerance of `simple heartbeat` test #1034

Closed etan-status closed 8 months ago

etan-status commented 8 months ago

The simple heartbeat test is flaky:

================
  /home/runner/work/nim-libp2p/nim-libp2p/tests/testnative 'Heartbeat::simple heartbeat'
----------------
    /home/runner/work/nim-libp2p/nim-libp2p/tests/testheartbeat.nim(31, 10): Check failed: i in 9 .. 11
    i was 12
    9 .. 11 was 9 .. 11

  [FAILED ] (  0.33s) simple heartbeat

Increase its timing tolerances to reduce the likelihood of this happening under load.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.75%. Comparing base (e9b4561) to head (7914861).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1034/graphs/tree.svg?width=650&height=150&src=pr&token=UR5JRQ249W&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1034?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) ```diff @@ Coverage Diff @@ ## unstable #1034 +/- ## ========================================= Coverage 82.75% 82.75% ========================================= Files 91 91 Lines 15616 15616 ========================================= Hits 12923 12923 Misses 2693 2693 ```