search

vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
242 stars 52 forks source link

remove unused `LPStreamError` types #1048

Closed etan-status closed 4 months ago

etan-status commented 4 months ago

There are a handful of LPStreamError types that are fully unused. They can be removed.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.76%. Comparing base (44cada9) to head (16652b6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1048/graphs/tree.svg?width=650&height=150&src=pr&token=UR5JRQ249W&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) ```diff @@ Coverage Diff @@ ## unstable #1048 +/- ## ============================================ - Coverage 82.80% 82.76% -0.04% ============================================ Files 91 91 Lines 15564 15564 ============================================ - Hits 12887 12882 -5 - Misses 2677 2682 +5 ``` | [Files](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [libp2p/stream/lpstream.nim](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-bGlicDJwL3N0cmVhbS9scHN0cmVhbS5uaW0=) | `83.23% <ø> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1048/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)