search

vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
242 stars 52 forks source link

clean up triple lookup and avoid `KeyError` when adding muxer #1057

Closed etan-status closed 3 months ago

etan-status commented 3 months ago

When connecting to a peer, there are a couple aspects to be fixed:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.80%. Comparing base (ae13a0d) to head (3f0055b).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1057/graphs/tree.svg?width=650&height=150&src=pr&token=UR5JRQ249W&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) ```diff @@ Coverage Diff @@ ## unstable #1057 +/- ## ========================================= Coverage 82.79% 82.80% ========================================= Files 91 91 Lines 15749 15750 +1 ========================================= + Hits 13040 13041 +1 Misses 2709 2709 ``` | [Files](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im) | Coverage Δ | | |---|---|---| | [libp2p/connmanager.nim](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im#diff-bGlicDJwL2Nvbm5tYW5hZ2VyLm5pbQ==) | `92.93% <100.00%> (+0.02%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/status-im/nim-libp2p/pull/1057/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=status-im)