codecov[bot]
commented
3 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.56%. Comparing base (
08a48fa) to head (417922c).
Closed etan-status closed 3 months ago
codecov[bot]
commented
3 months ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.56%. Comparing base (
08a48fa) to head (417922c).
All of the internal protocol handlers are restricted to
{.raises.}of[CancelledError]. However, theLPProtoHandlertype is part of the public interface, and example / test code raises more errors than just[CancelledError]. The caller is aware of that andCatchableErroris caught.To allow annotating the internal handlers with the proper
{.raises.} annotation, support for an extraLPProtoHandler2is added. This is backward compatible as the oldLPProtoHandleris still allowed. Examples still compile fine. There is one test that needs a slight adjustment as it accesses the internalhandlerfield directly. That field needs to be renamed so that thetemplateis used instead.Eventually,
LPProtoHandlermay be phased out, with appropriate notices to users who define custom handlers and the migration requiring errors to be handled inside the handler instead of raising them. At this time, such a deprecation is not yet applied, especially while the internal logic is still relying on the previous handler flow.