search

vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
242 stars 52 forks source link

avoid cancelling send future #1075

Closed arnetheduck closed 3 months ago

arnetheduck commented 3 months ago

otherwise, the use of asyncSpawn results in breakage

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.51%. Comparing base (49a92e5) to head (5ed400d). Report is 2 commits behind head on unstable.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1075/graphs/tree.svg?width=650&height=150&src=pr&token=M88zHaQffJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p)](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p) ```diff @@ Coverage Diff @@ ## unstable #1075 +/- ## ============================================ - Coverage 82.57% 82.51% -0.07% ============================================ Files 91 91 Lines 15812 15848 +36 ============================================ + Hits 13057 13077 +20 - Misses 2755 2771 +16 ``` | [Files](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1075?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p) | Coverage Δ | | |---|---|---| | [libp2p/protocols/pubsub/pubsubpeer.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1075?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL3Byb3RvY29scy9wdWJzdWIvcHVic3VicGVlci5uaW0=) | `88.23% <0.00%> (-0.35%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1075/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p)
diegomrsantos commented 3 months ago

supersedes https://github.com/vacp2p/nim-libp2p/pull/1074

diegomrsantos commented 2 months ago

@arnetheduck my local nimbus node crashed when running using unstable:

libbacktrace error: no debugging symbols available. Compile with '--debugger:native'. Error: unhandled exception: Asynchronous task [sendMsgSlow() at pubsubpeer.nim:303] was cancelled! [FutureDefect]