search

vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
240 stars 52 forks source link

cleanups #1092

Closed arnetheduck closed 1 month ago

arnetheduck commented 1 month ago
kaiserd commented 1 month ago

moving the gossipsub cleanups in a separate PR.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (02c96fc) to head (354513b). Report is 3 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092/graphs/tree.svg?width=650&height=150&src=pr&token=M88zHaQffJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p)](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p) ```diff @@ Coverage Diff @@ ## master #1092 +/- ## ========================================== - Coverage 84.53% 84.51% -0.03% ========================================== Files 91 91 Lines 15517 15529 +12 ========================================== + Hits 13118 13125 +7 - Misses 2399 2404 +5 ``` | [Files](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p) | Coverage Δ | | |---|---|---| | [libp2p/multiaddress.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Fmultiaddress.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL211bHRpYWRkcmVzcy5uaW0=) | `86.93% <ø> (ø)` | | | [libp2p/protocols/pubsub/gossipsub/behavior.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Fprotocols%2Fpubsub%2Fgossipsub%2Fbehavior.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL3Byb3RvY29scy9wdWJzdWIvZ29zc2lwc3ViL2JlaGF2aW9yLm5pbQ==) | `89.02% <100.00%> (+0.19%)` | :arrow_up: | | [libp2p/protocols/pubsub/gossipsub/scoring.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Fprotocols%2Fpubsub%2Fgossipsub%2Fscoring.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL3Byb3RvY29scy9wdWJzdWIvZ29zc2lwc3ViL3Njb3Jpbmcubmlt) | `90.06% <ø> (-0.13%)` | :arrow_down: | | [libp2p/protocols/pubsub/pubsub.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Fprotocols%2Fpubsub%2Fpubsub.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL3Byb3RvY29scy9wdWJzdWIvcHVic3ViLm5pbQ==) | `84.29% <ø> (ø)` | | | [libp2p/protocols/pubsub/rpc/messages.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Fprotocols%2Fpubsub%2Frpc%2Fmessages.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL3Byb3RvY29scy9wdWJzdWIvcnBjL21lc3NhZ2VzLm5pbQ==) | `52.85% <ø> (ø)` | | | [libp2p/transports/tcptransport.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Ftransports%2Ftcptransport.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL3RyYW5zcG9ydHMvdGNwdHJhbnNwb3J0Lm5pbQ==) | `80.57% <100.00%> (ø)` | | | [libp2p/multistream.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Fmultistream.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL211bHRpc3RyZWFtLm5pbQ==) | `86.17% <50.00%> (+0.07%)` | :arrow_up: | | [libp2p/protocols/pubsub/mcache.nim](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092?src=pr&el=tree&filepath=libp2p%2Fprotocols%2Fpubsub%2Fmcache.nim&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p#diff-bGlicDJwL3Byb3RvY29scy9wdWJzdWIvbWNhY2hlLm5pbQ==) | `82.75% <91.66%> (-9.25%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/vacp2p/nim-libp2p/pull/1092/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vacp2p)