chore(gossipsub): cleanups

vacp2p / nim-libp2p

libp2p implementation in Nim

https://vacp2p.github.io/nim-libp2p/docs/

MIT License

240 stars 52 forks source link

chore(gossipsub): cleanups #1096

Closed kaiserd closed 1 month ago

kaiserd commented 1 month ago

factored out from: https://github.com/vacp2p/nim-libp2p/pull/1092

add some docs
add missing penalty for invalid messages
simplify code
remove unused gossipsub fields

diegomrsantos commented 1 month ago

Should we use the conventional commits style for the PR's names?

kaiserd commented 1 month ago

Yes. Good point. I'll edit.

(Main application for conventional commits though are the commit messages themselves, since they are used for compiling the version summary. I'm editing the git commit messages for the squash commit to fit conventional commits.)

diegomrsantos commented 1 month ago

I believe the PR title is used as the commit message that will end up in the master branch when we squash and merge the PR.

kaiserd commented 1 month ago

Oh, yes, true. I sometimes add more sub-points to it.

kaiserd commented 1 month ago

LGTM. @diegomrsantos can we merge this?