fix(services): setup services before peerinfo is updated

vacp2p / nim-libp2p

libp2p implementation in Nim

https://vacp2p.github.io/nim-libp2p/docs/

MIT License

240 stars 52 forks source link

fix(services): setup services before peerinfo is updated #1120

Closed diegomrsantos closed 3 weeks ago

diegomrsantos commented 3 weeks ago

Setup services before peerinfo is updated - this allows services to set address mappers.
Fix HP interop tests - improve condition related to relay addr being published.
Disable wildcard resolver in testautonatservice and test testautorelay.

kaiserd commented 3 weeks ago

Thank you. Why do disable testautonatservice and test testautorelay fail with the wildcard resolver being active?

diegomrsantos commented 3 weeks ago

Thank you. Why do disable testautonatservice and test testautorelay fail with the wildcard resolver being active?

Cause now peerInfo.addrs is populated with the resolved addresses right after the switch is started and the tests are probably not expecting that.

kaiserd commented 3 weeks ago

Let's add an issue capturing the task of adjusting these tests so that we can add them back in. For now, this PR is OK.