search

vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
251 stars 55 forks source link

code coverage workflow is failing #1199

Open diegomrsantos opened 1 month ago

diegomrsantos commented 1 month ago

We don't see coverage info on PRs anymore

It's possible to see the failure here https://github.com/vacp2p/nim-libp2p/actions/runs/10958882042/job/30430060780?pr=1183

AlejandroCabeza commented 1 month ago

The reason why coverage is failing is because we've reached the rate limit. I recall adding a prevention measure during the CI refactor but it was disregarded. That being said, I think we would've reached the limit anyway.

The solution would be to go for a paid solution so we have a broader rate limit. Although maybe we won't hit the limit next month.

diegomrsantos commented 1 month ago

Which plan is best for me? Developer - this plan is best for open-source projects and offers unlimited uploads or for single-user teams with small private repos and up to 250 coverage uploads per month.

AlejandroCabeza commented 1 month ago

Which plan is best for me? Developer - this plan is best for open-source projects and offers unlimited uploads or for single-user teams with small private repos and up to 250 coverage uploads per month.

I don't think I follow your point. If you're trying to suggest 250 should be enough, that's exactly what I implied with my "maybe we won't hit the limit next month".