vacp2p / nim-libp2p

libp2p implementation in Nim
https://vacp2p.github.io/nim-libp2p/docs/
MIT License
249 stars 54 forks source link

Daily workflow could fail randomly with [OSError] #972

Open romanzac opened 12 months ago

romanzac commented 12 months ago

When running "Daily" workflows, they might fail during tests phase with:

Error: unhandled exception: FAILED: nimble testdaemon [OSError]

Preceding error about accepting connections might be related: 2023-10-26T07:36:31.057Z ERROR p2pd go-libp2p-daemon/daemon.go:145 error accepting connection {"error": "accept unix /tmp/nim-p2pd-12343-8.sock: use of closed network connection"}

More logs:

AMD64:

/ip4/10.212.7.153/tcp/51366 /ip4/127.0.0.1/tcp/51366 /ip6/::1/tcp/51367 Control socket: /unix/tmp/nim-p2pd-12343-9.sock Peer ID: QmSBH4d1gHHWrxjbqaqujZsXnMJ58YoJ8Ysgx45wdHnL9i Peer Addrs: /ip4/10.212.7.153/tcp/51370 /ip4/127.0.0.1/tcp/51370 /ip6/::1/tcp/51371 2023-10-26T07:36:31.057Z ERROR p2pd go-libp2p-daemon/daemon.go:145 error accepting connection {"error": "accept unix /tmp/nim-p2pd-12343-8.sock: use of closed network connection"} 2023-10-26T07:36:31.060Z ERROR p2pd go-libp2p-daemon/daemon.go:145 error accepting connection {"error": "accept unix /tmp/nim-p2pd-12343-9.sock: use of closed network connection"} . (12.7s) [Summary ] 4 tests run: 4 OK, 0 FAILED, 0 SKIPPED Error: execution of an external program failed: '/Users/runner/work/nim-libp2p/nim-libp2p/tests/testdaemon ' stack trace: (most recent call last) /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nimblecache-946033505/nimscriptapi_688942081.nim(187, 16) /Users/runner/work/nim-libp2p/nim-libp2p/libp2p.nimble(62, 10) testdaemonTask /Users/runner/work/nim-libp2p/nim-libp2p/libp2p.nimble(43, 8) runTest /Users/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(273, 7) exec /Users/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(273, 7) Error: unhandled exception: FAILED: nim c -d:debug --styleCheck:usages --styleCheck:error --verbosity:0 --hints:off --skipParentCfg --skipUserCfg -f --threads:on --opt:speed --gc:refc -d:libp2p_pubsub_sign=true -d:libp2p_pubsub_verify=true -r tests/testdaemon [OSError] Error: Exception raised during nimble script execution stack trace: (most recent call last) /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/nimblecache-946033505/nimscriptapi_688942081.nim(187, 16) /Users/runner/work/nim-libp2p/nim-libp2p/libp2p.nimble(90, 8) testTask /Users/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(273, 7) exec /Users/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(273, 7) Error: unhandled exception: FAILED: nimble testdaemon [OSError] Error: Exception raised during nimble script execution Error: Process completed with exit code 1.

i386:

/tmp/nimble_40229/githubcom_ftsfnico/nico.nim(1980, 56) Warning: hflip, vflip all have default value 'false', this may be unintentional, either use ';' (semicolon) or explicitly write each default value [ImplicitDefaultValue] /tmp/nimble_40229/githubcom_ftsfnico/nico.nim(2227, 19) Error: type mismatch: got '(int, int, int32, int32)' for '(int(x), int(y), src.w scale, src.h scale)' but expected 'Rect = tuple[x: int, y: int, w: int, h: int]' Tip: 225 messages have been suppressed, use --verbose to show them. nimble.nim(229) buildFromDir

Error:  Build failed for the package: nico

stack trace: (most recent call last) /tmp/nimblecache-946033505/nimscriptapi_326721641.nim(210, 16) /home/runner/work/nim-libp2p/nim-libp2p/libp2p.nimble(121, 3) examples_buildTask /home/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(265, 7) exec /home/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(265, 7) Error: unhandled exception: FAILED: nimble install -y nico [OSError] Tip: 201 messages have been suppressed, use --verbose to show them. nimscriptwrapper.nim(160) execScript

Error:  Exception raised during nimble script execution

stack trace: (most recent call last) Tip: 201 messages have been suppressed, use --verbose to show them. nimscriptwrapper.nim(160) execScript

Error:  Exception raised during nimble script execution

/tmp/nimblecache-946033505/nimscriptapi_326721641.nim(210, 16) /home/runner/work/nim-libp2p/nim-libp2p/libp2p.nimble(93, 3) testTask /home/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(265, 7) exec /home/runner/work/nim-libp2p/nim-libp2p/nim/lib/system/nimscript.nim(265, 7) Error: unhandled exception: FAILED: nimble examples_build [OSError]

romanzac commented 12 months ago

Several other problems exist with tests in Daily workflow. I have isolated tests causing problems and commented them out till they get fixed.

Disabled tests/examples:

amd64 - Nim 1.6/2.0: testdaemon tests/pubsub/testpubsub

i386 - Nim 2.0: examples_build

i386/amd64 - Nim Devel: testdaemon testinterop

romanzac commented 11 months ago

Issue will be solved by improving test stability and moving least supported or experimental architectures from the workflow.

romanzac commented 11 months ago

Adding #975