Production-worthy laundry list

Menduist commented 2 years ago

[ ] https://github.com/status-im/nim-quic/blob/084413c986de1e3e61700b802bf3a8ea4f270f7f/quic/helpers/bits.nim#L4 - we avoid range due to several issues with the semantics surrounding it
[ ] an external non-global randomness source should be used: https://github.com/status-im/nim-quic/blob/main/quic/transport/connectionid.nim#L18
[ ] nimble does not have a dependency resolver that is able to correctly deal with versions, so we don't use versions in nimble files, in general: https://github.com/status-im/nim-quic/blob/main/quic.nimble
[ ] I don't see cancellation support - maybe it just works, but it at least needs review
[x] re upraises, I'd probably go for moving a smaller version of it into nim-quic itself similar to the removal of questionable

cc @arnetheduck

arnetheduck commented 4 months ago

upraises no longer relevant with the move to nim 1.6+

diegomrsantos commented 2 months ago

@arnetheduck is the second task still relevant? If so, could you elaborate on it?

arnetheduck commented 4 weeks ago

yes, it's relevant, look for newRng in libp2p

vacp2p / nim-quic