search

vacp2p / rfc

Modular p2p messaging stack, with a focus on secure messaging.
https://rfc.vac.dev/
115 stars 15 forks source link

72/WAKU-RLN-KEYSTORE: add new RFC #631

Closed jimstir closed 6 months ago

jimstir commented 10 months ago

New RFC for 72/WAKU-RLN-KEYSTORE

kaiserd commented 10 months ago

Thank you :). Converting this to a draft PR for now. Feel free to open it for review, once you feel it is ready for a first review round.

(Just glancing over it, I saw a few spots that do not follow sembr.)

kaiserd commented 10 months ago

@jimstir see my comment here: https://github.com/vacp2p/rfc/pull/629 The directory structure is mixed up.

Also, you named this document waku-keystore.md. It should be XX/README.md As discussed, feel free to allocate the next new RFC number, and also name this PR accordingly please. In this case, it would be 72/ Generally, just check the existing RFCs, issues and PRs, and assign the next free number. If deemed necessary in the future, we might come up with a different number allocation process, but for now, this is the simplest and straightforward.

jimstir commented 10 months ago

@kaiserd Created this draft in the old repo and did not notice. I deleted the keystore file from the push notification repo and changed the name in this repo.

jimstir commented 10 months ago

@kaiserd ready for review

rymnc commented 8 months ago

hey @jimstir let me know if this is ready for another pass! thanks

jimstir commented 8 months ago

hey @jimstir let me know if this is ready for another pass! thanks

@rymnc I am ready for another round of feedback, thank you.

jimstir commented 6 months ago

Continue discussion: https://github.com/waku-org/specs/pull/2. The RFC process has been changed separating raw specs and the draft/stable specs into different repositories.