search

vacp2p / rfc

Modular p2p messaging stack, with a focus on secure messaging.
https://rfc.vac.dev/
115 stars 15 forks source link

chore: update Deterministic message hashing algorithm. #632

Closed ABresting closed 10 months ago

ABresting commented 10 months ago

As discussed, Updating the Deterministic message hashing computation, adding the sender timestamp in computation. It will make the message hash more unique.

richard-ramos commented 10 months ago

The change looks good to me, I'm just wondering if this could this cause any backward compatibility issues? The reason I ask is because the versions of status desktop/mobile running are heterogeneous so there will be clients using older version of the hash algorithm

ABresting commented 10 months ago

The change looks good to me, I'm just wondering if this could this cause any backward compatibility issues? The reason I ask is because the versions of status desktop/mobile running are heterogeneous so there will be clients using older version of the hash algorithm

Currently, this function is not used by anything in old devices/client since this function will be used by the new DB column hash, the sync protocol will only be able to sync with new/updated devices?