fix: disallow dupe registrations

vacp2p / rln-contract

RLN contract

Apache License 2.0

13 stars 6 forks source link

fix: disallow dupe registrations #12

Closed rymnc closed 1 year ago

rymnc commented 1 year ago

Previously, it was not possible to detect duplicate pubkey registrations. This PR addresses that, and modifies the function signatures since we do not need the pubkeyIndex to slash a given peer.

Note:

This same change will be reflected in https://github.com/vacp2p/rln-interep-contract, but the test will look different due to different testing procedures

When this PR is approved I'll create a companion pr on the rln-interep-contract repo.

oskarth commented 1 year ago

Before merging, can we get a review from someone at PSE? Just as a sanity check

rymnc commented 1 year ago

Approved by @curryrasul and @AtHeartEngineer - https://discord.com/channels/864066763682218004/905333924476108800/1047599833269145741