search

vacp2p / rln-contract

RLN contract
Apache License 2.0
13 stars 6 forks source link

fix: make tests compile with forge-std@1.6.0 #24

Closed 0x-r4bbit closed 1 year ago

0x-r4bbit commented 1 year ago

There was a breaking change introduced in forge-std at https://github.com/foundry-rs/forge-std/pull/407 which breaks compilation of Rln.t.sol with forge-std@v1.6.0.

This commit updates the dependency to v1.6.0 and adjusts the test source such that it successfully compiles.

Another way to go about this would've been to just stick with v1.5.6. and ensuring installation of that version. However, I've decided to update the dependency to the latest stable version instead.

github-actions[bot] commented 1 year ago

LCOV of commit 830cace during CI #29

Summary coverage rate:
  lines......: 83.9% (496 of 591 lines)
  functions..: 48.0% (12 of 25 functions)
  branches...: 52.5% (21 of 40 branches)

Files changed coverage rate: n/a
0x-r4bbit commented 1 year ago

Unfortunately, GitHub still doesn't support preserving PGP verified signatures of a commit when using the "Rebase & Merge" button via the web interface, hence the merged commit is now marked as not verified.

Switching to "Squash and merge" instead for future PRs.