PoC: onchain rln tree + root

rymnc commented 9 months ago

Description

This PR includes 2 important changes -

Integrate BinaryIMT (edit LazyIMT) into the Rln contract to allow for trustless root computation for lighter verifiers, reference: https://github.com/waku-org/research/issues/56
Moves the codebase over the the vacp2p/foundry-template, since verification of these contracts is failing due to an etherscan bug between etherscan <> hardhat-deploy. Saw this as an opportunity to port the repo.

Apologies for the large PR, but please note that most of the changes are restricted to Rln.sol, and a new function computeRoot. The tests remain the same, with some additional testing for compatibility with zerokit.

github-actions[bot] commented 9 months ago

LCOV of commit `ea4a157` during CI #49

Summary coverage rate:
  lines......: 30.4% (41 of 135 lines)
  functions..: 52.0% (13 of 25 functions)
  branches...: 52.5% (21 of 40 branches)

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  contracts/PoseidonHasher.sol| 100%      1| 100%     1|    -      0
  contracts/RlnBase.sol       | 100%     37| 100%     8| 100%     18

rymnc commented 9 months ago

@alrevuelta as requested,

{
  "RLN": {
    "polygonZkevmTestnet": "https://testnet-zkevm.polygonscan.com/address/0xC568eF58009b8e5B8824d9fbB271141782545538#",
    "sepolia": "https://sepolia.etherscan.io/address/0xbE24C8d709754523D882D4b67C59e983107cf1E8"
  }
}

github-actions[bot] commented 9 months ago

LCOV of commit `caa3d3b` during CI #51

Summary coverage rate:
  lines......: 29.9% (40 of 134 lines)
  functions..: 50.0% (12 of 24 functions)
  branches...: 52.5% (21 of 40 branches)

Files changed coverage rate:
                           |Lines       |Functions  |Branches    
  Filename                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================
  contracts/RlnBase.sol    | 100%     37| 100%     8| 100%     18
  test/RLNApp.t.sol        | 100%      2| 100%     2|75.0%      4

github-actions[bot] commented 9 months ago

LCOV of commit `a3193ce` during CI #52

Summary coverage rate:
  lines......: 33.8% (48 of 142 lines)
  functions..: 52.0% (13 of 25 functions)
  branches...: 52.3% (23 of 44 branches)

Files changed coverage rate:
                           |Lines       |Functions  |Branches    
  Filename                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================
  contracts/RlnBase.sol    | 100%     45| 100%     9|90.9%     22
  test/RLNApp.t.sol        | 100%      2| 100%     2|75.0%      4

alrevuelta commented 3 months ago

Can we close this since the LazyIMT was integrated successfully here? https://github.com/waku-org/waku-rlnv2-contract

vacp2p / rln-contract