Gennet: traits and complete configurability

[0xFugue]

Gennet can now handle all the parameters of nwaku and most of gowaku parameters

• Each node / a set of nodes can now select/set any and all of the akunode parameters.
• Each logical category (say rln, relay, filter, lightpush, discv5, store etc) is now added as a trait and these traits are specified as a trait string. A trait string looks like "nwaku:rln:discv5:store": this specifies a nwaku node with store, discv5, rln capabilities.
• Each trait has a toml associated with it and Gennet composes these tomls to get the final, per-node toml
• The node distributions can be specified as {"nwaku:rln:discv5:store":80, "gowaku:dnsdisc:swap":20}. the values are percentages. Appropriate validations are added to the code.
• User defined traits can be added.

fixes #62

[0xFugue]

I have a couple of suggestions.

Also, there are still no tests. How are you doing about this? Do you have any problems? I am asking before this will be much easier to test if functions are smaller and if they follow single responsability principle. I also think we should start separating this into several files as it is starting to get messy.

Another question is that I found a lot of spaces between after if statements. I mentioned one in the reviews. It would be nice if we all stick to PEP-8 as we initially agreed, so everyone is in the same page!

Pls recollect that what we discussed it on Monday: the plan is to do the traits and then the tests.

That said, we do need to concentrate on getting the actual runs sorted out and get the data out; and validate the data. My priority atm is to sort out docker stat and analysis/plot so that we will have at least one robust data collector that never fails.

[AlbertoSoutullo]

I have a couple of suggestions. Also, there are still no tests. How are you doing about this? Do you have any problems? I am asking before this will be much easier to test if functions are smaller and if they follow single responsability principle. I also think we should start separating this into several files as it is starting to get messy. Another question is that I found a lot of spaces between after if statements. I mentioned one in the reviews. It would be nice if we all stick to PEP-8 as we initially agreed, so everyone is in the same page!

Pls recollect that what we discussed it on Monday: the plan is to do the traits and then the tests.

That said, we do need to concentrate on getting the actual runs sorted out and get the data out; and validate the data. My priority atm is to sort out docker stat and analysis/plot so that we will have at least one robust data collector that never fails.

Yup, just wanted to know how the stuff was going. Also, feel free to resolve conversations if you fix something I requested, so I don't have to be tracking every comment if it is already resolved!

Also, when the changes are done, re-ask me for review so I get a notification and I am sure you want another review