vacp2p / wakurtosis

4 stars 3 forks source link

Discv5 #129

Closed AlbertoSoutullo closed 1 year ago

AlbertoSoutullo commented 1 year ago

Discv5 now works on simulations. Kurtosis can't modify dinamically created files. So the option of integrating Gennet in Kurtosis is not viable.

Also, we need the ENR of the bootstrap node before instantiating all other nodes, since this is a parameter that can only be set up when you first run the node.

To solve this, in run.sh we add a boostrap node to the enclave in a similar way we add cAdvisor. Then, we query the node to get its ENR, and then we modify the discv5 template, so if discv5 is used, this ENR will be passed to all nodes that will use it.

Summary of changes:

Closes #123 , closes #120 , closes #118 , closes #78

Daimakaimura commented 1 year ago

Looks good. Is Discv5 enabled by default? I want to try this but I m not sure if there is anything else that I need to do

AlbertoSoutullo commented 1 year ago
  • be correctly enabled now

You have to set it in the gennet traits configuration. But the bootstrapnode will be prepared beforehand yes. I wanted to make a check to activate it depending on if we used that trait or not, but the way traits are handled by gennet makes it a bit messy. So a bootstrap node will be instantiated by default. Then, if you put discv5 in gennet traits, they will connect to it directly. You can use the flag "interconnect_nodes" to skip or not the topology connection.

And now I just realized I didn't update some stuff I wanted to do, let me put this as draft for 30 minutes, then I will comment again when this is ready. My bad.