vacp2p / wakurtosis

4 stars 3 forks source link

Gennet container integration #44

Closed AlbertoSoutullo closed 1 year ago

AlbertoSoutullo commented 1 year ago

So in this PR we are setting a workflow with run.sh, where:

Also, a build.sh was made, only for installing Docker and Kurtosis.

Closes #40

AlbertoSoutullo commented 1 year ago

four issues. first, let's pls keep the command line arguments ( so that gennet can be used in shell scripts as well; we will keep typr ) and prioritise command line inputs over yaml inputs: just like what wakunodes do. that is, if there is a conflict between yaml and commandline params, the command line will take precedence. this will make gennet play well in scripts.

I guess you are referring to the yml for gennet. Yes, I should have commented that all paremeters should be in the same configuration file. And yes, that is a good idea, I will change the code so there are commandline params and also a file, and command line will take precedence.

second, please let me know why we use yaml here; we already use json and toml. as things stand, the end users of our tool will need to understand 3 different input file formats to make sense of what info is coming from where.

As I mention before, this will be changed and all parameters will be in the same json file, so its easy to configure what you want to do.

third, it is better practice to not to hardcore the output directory inside gennet code; specifying a hard path in the dockerfile (so that you call pull the same file with docker cp later) is a better. again, this allows the gennet to be used independently. so let's keep the parameter list as it is, thanks.

What do you mean? It is what is being done here. Gennet will output the generated topology into a folder inside the repo. I can add where do you want this results to be created, but as a default it is ok for everyone to get them created, and then we add this to a volume that will be used within Kurtosis.

fourth, let's upgrade to 0.64.1 and use kurtosis files download for pulling files from 'images'. that will be portable between docker and k8s.

I will need to change a lot of starlark code for that, so I will do this in a separated PR.

If you would like, would be happy to do the all of this either here, or in a separate PR, cheers.

So as a summary, changes for the next PR:

I will fix the conflics because of the other PR and I will ping you to approve this again.