vacp2p / wakurtosis

4 stars 3 forks source link

Gennet/Kurtosis info into WLS with master changes #97

Closed AlbertoSoutullo closed 1 year ago

AlbertoSoutullo commented 1 year ago

Another big PR, changes:

Remember that in order to test the tests in starlark, you have to change the name of tests.star to main.star and do kurtosis run . while this process is not automatized with CI.

In order to run python tests, you can go to the desired directory (as wls-module) and run python -m unittest discover .

Closes #49 , closes #88 , closes #94 ,

AlbertoSoutullo commented 1 year ago

Glad we all switched to dispatchers! The WSL injection seems like a busy loop: if _time_to_send_next_message(...) is false, may be it is better to sleep for the remaining time as opposed to spin in while True. But LGTM otherwise.

This is indeed super good feedback and you are right. I would change it but we are planning to change this to non-blocking message inyection so it will be changed anyway.