Closed AlbertoSoutullo closed 1 year ago
Glad we all switched to dispatchers! The WSL injection seems like a busy loop: if
_time_to_send_next_message(...)
is false, may be it is better to sleep for the remaining time as opposed to spin inwhile True
. But LGTM otherwise.
This is indeed super good feedback and you are right. I would change it but we are planning to change this to non-blocking message inyection so it will be changed anyway.
Another big PR, changes:
wls.star
to use base64 payloads--port-shift
value when preparing ports in Kurtosis--port-shift
value when preparing CMD in Kurtosisconfig.json
insteadwls.yaml
action=store_true
) making argparser not working correctly if arguments were passed.uniform
mode in wls was not working correctly in WLS. Fixed.Remember that in order to test the tests in starlark, you have to change the name of
tests.star
tomain.star
and dokurtosis run .
while this process is not automatized with CI.In order to run python tests, you can go to the desired directory (as
wls-module
) and runpython -m unittest discover .
Closes #49 , closes #88 , closes #94 ,