vacp2p / zerokit

A set of Zero Knowledge modules, written in Rust and designed to be used in other system programming environments.
Apache License 2.0
130 stars 7 forks source link

leave our fork of `ark-circom` #132

Closed tyshko-rostyslav closed 1 year ago

tyshko-rostyslav commented 1 year ago

Blocked by this: https://github.com/gakonst/ark-circom/pull/45

rymnc commented 1 year ago

@tyshko-rostyslav can you compile the rln-wasm crate and share the size of the pkg generated?

tyshko-rostyslav commented 1 year ago

@tyshko-rostyslav can you compile the rln-wasm crate and share the size of the pkg generated?

sure, I'll add them today

tyshko-rostyslav commented 1 year ago

@rymnc pkg directory is 668 KB

rymnc commented 1 year ago

@rymnc pkg directory is 668 KB

current master =>

➜  rln-wasm git:(master) du -shc pkg/*                                   
4.0K    pkg/README.md
4.0K    pkg/package.json
8.0K    pkg/rln_wasm.d.ts
 28K    pkg/rln_wasm.js
448K    pkg/rln_wasm_bg.wasm
4.0K    pkg/rln_wasm_bg.wasm.d.ts
496K    total

this branch =>

➜  rln-wasm git:(rostyslavtyshko/issue37) du -shc pkg/*   
4.0K    pkg/README.md
4.0K    pkg/package.json
8.0K    pkg/rln_wasm.d.ts
 28K    pkg/rln_wasm.js
580K    pkg/rln_wasm_bg.wasm
4.0K    pkg/rln_wasm_bg.wasm.d.ts
628K    total

thats a big jump!

tyshko-rostyslav commented 1 year ago

@rymnc pkg directory is 668 KB

current master =>

➜  rln-wasm git:(master) du -shc pkg/*                                   
4.0K  pkg/README.md
4.0K  pkg/package.json
8.0K  pkg/rln_wasm.d.ts
 28K  pkg/rln_wasm.js
448K  pkg/rln_wasm_bg.wasm
4.0K  pkg/rln_wasm_bg.wasm.d.ts
496K  total

this branch =>

➜  rln-wasm git:(rostyslavtyshko/issue37) du -shc pkg/*   
4.0K  pkg/README.md
4.0K  pkg/package.json
8.0K  pkg/rln_wasm.d.ts
 28K  pkg/rln_wasm.js
580K  pkg/rln_wasm_bg.wasm
4.0K  pkg/rln_wasm_bg.wasm.d.ts
628K  total

thats a big jump!

I have a less dramatic surge - about 70 KB. I've taken a look at cargo tree duplicates, and this branches' version has less! (though hashbrown has different version duplicates).