vacp2p / zerokit

A set of Zero Knowledge modules, written in Rust and designed to be used in other system programming environments.
Apache License 2.0
130 stars 7 forks source link

move to uncompressed versions #161

Closed tyshko-rostyslav closed 1 year ago

rymnc commented 1 year ago

@tyshko-rostyslav can we rebase this pr to master?

github-actions[bot] commented 1 year ago

Benchmark for b1d5662

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | 1274.8±0.77ns | **1272.2±5.70ns** | **-0.20%** | | FullMerkleTree::get | 3.0±0.00ns | 3.0±0.00ns | 0.00% | | FullMerkleTree::override_range | 3.2±0.03µs | 3.2±0.00µs | 0.00% | | FullMerkleTree::set | 1269.1±1.06ns | 1268.7±0.72ns | -0.03% | | OptimalMerkleTree::compute_root | 1432.0±0.72ns | **1414.7±0.99ns** | **-1.21%** | | OptimalMerkleTree::delete | 1426.3±0.63ns | **1420.7±0.74ns** | **-0.39%** | | OptimalMerkleTree::get | 26.0±0.03ns | **25.6±0.04ns** | **-1.54%** | | OptimalMerkleTree::override_range | 7.2±0.00µs | 7.2±0.02µs | 0.00% | | OptimalMerkleTree::set | 1440.3±15.68ns | **1418.4±0.90ns** | **-1.52%** |
github-actions[bot] commented 1 year ago

Benchmark for b1d5662

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Pmtree::compute_root | 2.0±0.00ns | 2.0±0.01ns | 0.00% | | Pmtree::get | **453.4±1.26ns** | 455.3±0.53ns | **+0.42%** | | Pmtree::override_range | 173.5±4.81µs | 176.9±13.62µs | +1.96% | | Pmtree::set | 70.6±0.06µs | **69.3±0.07µs** | **-1.84%** | | Pmtree:delete | 69.5±0.04µs | **69.4±0.05µs** | **-0.14%** |
github-actions[bot] commented 1 year ago

Benchmark for f94be26

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.1±0.00ns | 0.1±0.00ns | 0.00% | | FullMerkleTree::delete | 1612.7±109.67ns | 1612.9±144.23ns | +0.01% | | FullMerkleTree::get | 3.9±0.23ns | 3.9±0.29ns | 0.00% | | FullMerkleTree::override_range | 4.0±0.29µs | 4.0±0.17µs | 0.00% | | FullMerkleTree::set | 1571.8±51.51ns | 1575.1±54.01ns | +0.21% | | OptimalMerkleTree::compute_root | 1737.9±54.66ns | 1762.6±100.38ns | +1.42% | | OptimalMerkleTree::delete | 1766.7±73.79ns | 1782.3±112.62ns | +0.88% | | OptimalMerkleTree::get | 33.9±3.94ns | 33.0±1.37ns | -2.65% | | OptimalMerkleTree::override_range | 8.9±0.39µs | 9.0±0.62µs | +1.12% | | OptimalMerkleTree::set | 1819.2±173.41ns | 1772.7±119.17ns | -2.56% |
github-actions[bot] commented 1 year ago

Benchmark for f94be26

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Pmtree::compute_root | 2.0±0.00ns | 2.0±0.01ns | 0.00% | | Pmtree::get | 465.6±0.33ns | **459.7±1.08ns** | **-1.27%** | | Pmtree::override_range | 173.1±5.42µs | 173.5±9.49µs | +0.23% | | Pmtree::set | **70.3±0.78µs** | 70.9±0.13µs | **+0.85%** | | Pmtree:delete | **69.7±0.06µs** | 71.1±0.06µs | **+2.01%** |
rymnc commented 1 year ago

@tyshko-rostyslav curious, why was this closed?

tyshko-rostyslav commented 1 year ago

@tyshko-rostyslav curious, why was this closed?

unsuccessful experiment

rymnc commented 1 year ago

I see! @richard-ramos, can you confirm this when you have the time please? (by using this branch in your tests?)

richard-ramos commented 1 year ago

Sure! i'll have a look now

richard-ramos commented 1 year ago

I'm getting results similar to these for executing this test, with almost all of that time spent generating the proof.

 Executed 1 of 1 SUCCESS (20.142 secs / 20.127 secs)