vacp2p / zerokit

A set of Zero Knowledge modules, written in Rust and designed to be used in other system programming environments.
Apache License 2.0
130 stars 7 forks source link

fix: add support to aarch64-linux-android #228

Closed richard-ramos closed 7 months ago

richard-ramos commented 7 months ago

Otherwise, it will complain about -lunwind not found due to reasons described in https://blog.rust-lang.org/2023/01/09/android-ndk-update-r25.html

rymnc commented 7 months ago

this will go into the rln-v2 release process, is that okay?

rymnc commented 7 months ago

err, please wait for checks to pass :)

github-actions[bot] commented 7 months ago

Benchmark for 0ea0731

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Pmtree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | Pmtree::get | 321.7±4.88ns | 325.3±6.34ns | +1.12% | | Pmtree::override_range | 245.3±6.66µs | 242.0±4.71µs | -1.35% | | Pmtree::set | 56.4±0.28µs | 56.4±0.60µs | 0.00% | | Pmtree:delete | 56.4±1.02µs | 56.4±0.59µs | 0.00% |
github-actions[bot] commented 7 months ago

Benchmark for 0ea0731

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | 882.7±11.85ns | **873.8±7.38ns** | **-1.01%** | | FullMerkleTree::get | **3.4±0.04ns** | 3.5±0.06ns | **+2.94%** | | FullMerkleTree::override_range | 2.2±0.01µs | 2.2±0.04µs | 0.00% | | FullMerkleTree::set | 896.2±67.87ns | **872.6±7.14ns** | **-2.63%** | | OptimalMerkleTree::compute_root | 1068.9±8.73ns | **1035.4±8.34ns** | **-3.13%** | | OptimalMerkleTree::delete | 1044.2±7.34ns | **1028.3±13.50ns** | **-1.52%** | | OptimalMerkleTree::get | 23.1±0.78ns | **22.3±0.18ns** | **-3.46%** | | OptimalMerkleTree::override_range | 5.3±0.05µs | **5.2±0.14µs** | **-1.89%** | | OptimalMerkleTree::set | 1065.7±13.62ns | **1027.0±18.22ns** | **-3.63%** |
richard-ramos commented 7 months ago

oops, sorry! I imagine the checks will pass since i modified Cross.toml only and that's not used in this project, but on go-zerokit-rln-*

richard-ramos commented 7 months ago

this will go into the rln-v2 release process, is that okay?

I also pushed it in https://github.com/vacp2p/zerokit/tree/v0.3.5-release commit history!

richard-ramos commented 7 months ago

Just learned that cross is used here too :)