search

vacp2p / zerokit

A set of Zero Knowledge modules, written in Rust and designed to be used in other system programming environments.
Apache License 2.0
130 stars 7 forks source link

chore(rln): add QoL traits to the Hasher associated type in MerkleTree trait #238

Closed rymnc closed 4 months ago

rymnc commented 4 months ago

Few QoL traits to assist debugging.

github-actions[bot] commented 4 months ago

Benchmark for 76d0766

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Pmtree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | Pmtree::get | **320.3±4.56ns** | 324.9±5.97ns | **+1.44%** | | Pmtree::override_range | 239.3±5.81µs | 238.2±7.16µs | -0.46% | | Pmtree::set | 55.8±0.44µs | 55.7±0.45µs | -0.18% | | Pmtree:delete | 56.2±2.69µs | 55.9±0.68µs | -0.53% |
github-actions[bot] commented 4 months ago

Benchmark for 76d0766

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | **873.1±13.25ns** | 893.8±15.76ns | **+2.37%** | | FullMerkleTree::get | **3.4±0.06ns** | 3.5±0.08ns | **+2.94%** | | FullMerkleTree::override_range | 2.2±0.02µs | 2.2±0.04µs | 0.00% | | FullMerkleTree::set | **874.5±13.75ns** | 903.5±8.51ns | **+3.32%** | | OptimalMerkleTree::compute_root | 1033.0±13.67ns | 1034.4±12.68ns | +0.14% | | OptimalMerkleTree::delete | 1029.2±15.46ns | 1038.7±12.47ns | +0.92% | | OptimalMerkleTree::get | 23.5±0.39ns | 23.4±0.38ns | -0.43% | | OptimalMerkleTree::override_range | 5.3±0.13µs | **5.2±0.04µs** | **-1.89%** | | OptimalMerkleTree::set | 1031.1±16.71ns | 1039.7±11.43ns | +0.83% |
github-actions[bot] commented 4 months ago

Benchmark for a846c15

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Pmtree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | Pmtree::get | 323.0±25.04ns | 324.4±7.80ns | +0.43% | | Pmtree::override_range | 235.4±3.25µs | 233.7±3.77µs | -0.72% | | Pmtree::set | 55.9±0.44µs | 55.7±0.38µs | -0.36% | | Pmtree:delete | 56.1±0.86µs | 56.0±1.28µs | -0.18% |
github-actions[bot] commented 4 months ago

Benchmark for a846c15

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | **873.7±13.22ns** | 886.9±6.34ns | **+1.51%** | | FullMerkleTree::get | 3.5±0.06ns | **3.4±0.03ns** | **-2.86%** | | FullMerkleTree::override_range | 2.2±0.01µs | 2.2±0.01µs | 0.00% | | FullMerkleTree::set | **873.8±6.83ns** | 883.3±11.92ns | **+1.09%** | | OptimalMerkleTree::compute_root | 1039.0±14.75ns | 1035.0±6.80ns | -0.38% | | OptimalMerkleTree::delete | 1027.0±12.70ns | 1029.0±8.09ns | +0.19% | | OptimalMerkleTree::get | 23.4±0.16ns | **23.2±0.37ns** | **-0.85%** | | OptimalMerkleTree::override_range | 5.2±0.08µs | 5.2±0.09µs | 0.00% | | OptimalMerkleTree::set | 1040.8±81.69ns | **1027.4±7.36ns** | **-1.29%** |