vacp2p / zerokit

A set of Zero Knowledge modules, written in Rust and designed to be used in other system programming environments.
Apache License 2.0
131 stars 7 forks source link

chore(rln): tests and benchmarks review #243

Closed seemenkina closed 5 months ago

seemenkina commented 5 months ago

Part of #237

This PR includes:

github-actions[bot] commented 5 months ago

Benchmark for cd2b2c1

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | 883.7±12.95ns | 887.2±14.00ns | +0.40% | | FullMerkleTree::get | 3.5±0.07ns | **3.4±0.05ns** | **-2.86%** | | FullMerkleTree::override_range | 2.2±0.04µs | 2.2±0.02µs | 0.00% | | FullMerkleTree::set | 888.6±8.74ns | 883.2±12.12ns | -0.61% | | OptimalMerkleTree::compute_root | 1036.1±12.79ns | 1032.5±19.81ns | -0.35% | | OptimalMerkleTree::delete | 1028.7±13.71ns | 1026.0±15.33ns | -0.26% | | OptimalMerkleTree::get | **23.0±0.24ns** | 23.3±1.04ns | **+1.30%** | | OptimalMerkleTree::override_range | 5.2±0.05µs | 5.2±0.06µs | 0.00% | | OptimalMerkleTree::set | 1028.6±15.70ns | 1024.4±14.05ns | -0.41% |
github-actions[bot] commented 5 months ago

Benchmark for 518666e

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | 890.2±14.10ns | 885.8±23.62ns | -0.49% | | FullMerkleTree::get | **3.4±0.05ns** | 3.5±0.09ns | **+2.94%** | | FullMerkleTree::override_range | 2.2±0.02µs | 2.2±0.03µs | 0.00% | | FullMerkleTree::set | 886.9±23.82ns | 884.1±9.26ns | -0.32% | | OptimalMerkleTree::compute_root | **1030.9±9.10ns** | 1058.3±7.39ns | **+2.66%** | | OptimalMerkleTree::delete | **1023.1±6.50ns** | 1052.9±18.36ns | **+2.91%** | | OptimalMerkleTree::get | **23.0±0.22ns** | 24.0±3.45ns | **+4.35%** | | OptimalMerkleTree::override_range | **5.2±0.15µs** | 5.4±0.24µs | **+3.85%** | | OptimalMerkleTree::set | **1024.8±8.05ns** | 1033.8±9.09ns | **+0.88%** |
github-actions[bot] commented 5 months ago

Benchmark for 518666e

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::full_height_gen | 14.0±0.04ms | N/A | N/A | | OptimalMerkleTree::full_height_gen | 552.6±11.12µs | N/A | N/A | | Pmtree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | Pmtree::get | 320.6±4.70ns | 323.1±4.39ns | +0.78% | | Pmtree::override_range | 230.7±3.21µs | 230.6±3.66µs | -0.04% | | Pmtree::set | 54.2±0.36µs | 54.5±0.50µs | +0.55% | | Pmtree:delete | 54.1±0.60µs | 54.6±1.38µs | +0.92% | | Set/FullMerkleTree::set/1 | 553.0±4.92µs | N/A | N/A | | Set/FullMerkleTree::set/10 | 5.5±0.03ms | N/A | N/A | | Set/FullMerkleTree::set/100 | 55.4±0.22ms | N/A | N/A | | Set/FullMerkleTree::set_range/1 | 551.5±5.27µs | N/A | N/A | | Set/FullMerkleTree::set_range/10 | 758.4±3.92µs | N/A | N/A | | Set/FullMerkleTree::set_range/100 | 3.3±0.01ms | N/A | N/A | | Set/OptimalMerkleTree::set/1 | 550.6±8.15µs | N/A | N/A | | Set/OptimalMerkleTree::set/10 | 5.5±0.02ms | N/A | N/A | | Set/OptimalMerkleTree::set/100 | 55.6±0.21ms | N/A | N/A | | Set/OptimalMerkleTree::set_range/1 | 551.5±2.95µs | N/A | N/A | | Set/OptimalMerkleTree::set_range/10 | 5.5±0.02ms | N/A | N/A | | Set/OptimalMerkleTree::set_range/100 | 56.0±0.20ms | N/A | N/A | | zkey::upload_from_folder | 3.3±0.00s | 3.3±0.00s | 0.00% |
github-actions[bot] commented 5 months ago

Benchmark for 2091e85

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | 900.8±14.23ns | 889.5±26.06ns | -1.25% | | FullMerkleTree::get | **3.4±0.07ns** | 3.5±0.05ns | **+2.94%** | | FullMerkleTree::override_range | 2.2±0.03µs | 2.2±0.03µs | 0.00% | | FullMerkleTree::set | 896.0±7.79ns | **885.4±12.41ns** | **-1.18%** | | OptimalMerkleTree::compute_root | 1047.7±8.44ns | **1039.0±15.87ns** | **-0.83%** | | OptimalMerkleTree::delete | 1069.1±33.03ns | 1042.6±63.12ns | -2.48% | | OptimalMerkleTree::get | **23.1±0.20ns** | 23.5±0.21ns | **+1.73%** | | OptimalMerkleTree::override_range | **5.2±0.02µs** | 5.3±0.14µs | **+1.92%** | | OptimalMerkleTree::set | 1057.0±7.99ns | **1036.5±18.90ns** | **-1.94%** |
github-actions[bot] commented 5 months ago

Benchmark for 2091e85

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::full_height_gen | 14.9±0.14ms | N/A | N/A | | OptimalMerkleTree::full_height_gen | 552.8±3.22µs | N/A | N/A | | Pmtree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | Pmtree::get | **320.3±3.44ns** | 331.8±2.91ns | **+3.59%** | | Pmtree::override_range | 232.0±3.15µs | 231.9±4.83µs | -0.04% | | Pmtree::set | 54.3±0.37µs | 54.3±0.88µs | 0.00% | | Pmtree:delete | 54.3±0.57µs | 54.3±0.36µs | 0.00% | | Set/FullMerkleTree::set/1 | 558.7±6.15µs | N/A | N/A | | Set/FullMerkleTree::set/10 | 5.6±0.01ms | N/A | N/A | | Set/FullMerkleTree::set/100 | 56.3±0.22ms | N/A | N/A | | Set/FullMerkleTree::set_range/1 | 557.1±7.06µs | N/A | N/A | | Set/FullMerkleTree::set_range/10 | 764.2±4.99µs | N/A | N/A | | Set/FullMerkleTree::set_range/100 | 3.3±0.01ms | N/A | N/A | | Set/OptimalMerkleTree::set/1 | 553.6±6.01µs | N/A | N/A | | Set/OptimalMerkleTree::set/10 | 5.6±0.02ms | N/A | N/A | | Set/OptimalMerkleTree::set/100 | 55.7±0.25ms | N/A | N/A | | Set/OptimalMerkleTree::set_range/1 | 553.6±7.72µs | N/A | N/A | | Set/OptimalMerkleTree::set_range/10 | 5.5±0.02ms | N/A | N/A | | Set/OptimalMerkleTree::set_range/100 | 55.7±0.37ms | N/A | N/A | | zkey::upload_from_folder | 3.3±0.00s | 3.3±0.00s | 0.00% |
github-actions[bot] commented 5 months ago

Benchmark for 484b980

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | 892.8±55.71ns | 898.3±15.39ns | +0.62% | | FullMerkleTree::get | 3.5±0.08ns | **3.4±0.04ns** | **-2.86%** | | FullMerkleTree::override_range | 2.2±0.03µs | 2.2±0.04µs | 0.00% | | FullMerkleTree::set | **886.1±8.18ns** | 909.7±12.10ns | **+2.66%** | | OptimalMerkleTree::compute_root | 1036.1±14.47ns | 1032.5±5.77ns | -0.35% | | OptimalMerkleTree::delete | 1032.9±31.56ns | 1027.2±12.45ns | -0.55% | | OptimalMerkleTree::get | 23.1±0.33ns | 22.8±0.37ns | -1.30% | | OptimalMerkleTree::override_range | 5.2±0.07µs | 5.2±0.04µs | 0.00% | | OptimalMerkleTree::set | 1029.2±35.42ns | 1030.0±16.84ns | +0.08% |
github-actions[bot] commented 5 months ago

Benchmark for 484b980

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::::full_height_gen | 14.5±0.13ms | N/A | N/A | | OptimalMerkleTree::::full_height_gen | 552.6±6.07µs | N/A | N/A | | Pmtree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | Pmtree::get | 323.7±6.02ns | **317.8±5.22ns** | **-1.82%** | | Pmtree::override_range | 234.2±3.32µs | 232.1±3.68µs | -0.90% | | Pmtree::set | 54.3±0.46µs | 54.3±0.59µs | 0.00% | | Pmtree:delete | 54.2±0.30µs | 54.3±0.33µs | +0.18% | | Set/FullMerkleTree::::set/1 | 555.8±5.99µs | N/A | N/A | | Set/FullMerkleTree::::set/10 | 5.6±0.03ms | N/A | N/A | | Set/FullMerkleTree::::set/100 | 55.6±0.21ms | N/A | N/A | | Set/FullMerkleTree::::set_range/1 | 558.5±5.90µs | N/A | N/A | | Set/FullMerkleTree::::set_range/10 | 761.8±6.82µs | N/A | N/A | | Set/FullMerkleTree::::set_range/100 | 3.3±0.01ms | N/A | N/A | | Set/OptimalMerkleTree::::set/1 | 551.6±5.79µs | N/A | N/A | | Set/OptimalMerkleTree::::set/10 | 5.5±0.01ms | N/A | N/A | | Set/OptimalMerkleTree::::set/100 | 55.8±0.22ms | N/A | N/A | | Set/OptimalMerkleTree::::set_range/1 | 555.9±8.10µs | N/A | N/A | | Set/OptimalMerkleTree::::set_range/10 | 5.5±0.02ms | N/A | N/A | | Set/OptimalMerkleTree::::set_range/100 | 55.8±0.25ms | N/A | N/A | | zkey::upload_from_folder | 3.3±0.00s | 3.3±0.01s | 0.00% |
github-actions[bot] commented 5 months ago

Benchmark for a1e4a07

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | FullMerkleTree::delete | 897.0±18.16ns | 885.7±19.70ns | -1.26% | | FullMerkleTree::get | **3.4±0.06ns** | 3.5±0.07ns | **+2.94%** | | FullMerkleTree::override_range | 2.2±0.01µs | 2.2±0.02µs | 0.00% | | FullMerkleTree::set | 896.0±90.48ns | **882.8±6.68ns** | **-1.47%** | | OptimalMerkleTree::compute_root | 1036.4±13.92ns | 1037.0±10.77ns | +0.06% | | OptimalMerkleTree::delete | 1030.8±16.08ns | 1030.0±8.46ns | -0.08% | | OptimalMerkleTree::get | **23.1±0.28ns** | 23.4±0.17ns | **+1.30%** | | OptimalMerkleTree::override_range | 5.3±0.07µs | **5.2±0.07µs** | **-1.89%** | | OptimalMerkleTree::set | **1029.5±5.34ns** | 1038.9±26.97ns | **+0.91%** |
github-actions[bot] commented 5 months ago

Benchmark for a1e4a07

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | FullMerkleTree::::full_height_gen | 15.3±0.28ms | N/A | N/A | | OptimalMerkleTree::::full_height_gen | 538.0±12.81µs | N/A | N/A | | Pmtree::compute_root | 0.0±0.00ns | 0.0±0.00ns | NaN% | | Pmtree::get | 322.0±4.29ns | **312.6±7.72ns** | **-2.92%** | | Pmtree::override_range | 232.4±6.06µs | 229.0±5.83µs | -1.46% | | Pmtree::set | 54.0±0.76µs | 53.3±1.13µs | -1.30% | | Pmtree:delete | 53.9±1.00µs | 53.3±1.73µs | -1.11% | | Set/FullMerkleTree::::set/1 | 551.7±5.12µs | N/A | N/A | | Set/FullMerkleTree::::set/10 | 5.5±0.05ms | N/A | N/A | | Set/FullMerkleTree::::set/100 | 55.1±0.68ms | N/A | N/A | | Set/FullMerkleTree::::set_range/1 | 539.0±14.52µs | N/A | N/A | | Set/FullMerkleTree::::set_range/10 | 749.5±14.35µs | N/A | N/A | | Set/FullMerkleTree::::set_range/100 | 3.2±0.07ms | N/A | N/A | | Set/OptimalMerkleTree::::set/1 | 542.7±13.73µs | N/A | N/A | | Set/OptimalMerkleTree::::set/10 | 5.5±0.08ms | N/A | N/A | | Set/OptimalMerkleTree::::set/100 | 54.5±0.97ms | N/A | N/A | | Set/OptimalMerkleTree::::set_range/1 | 548.9±14.01µs | N/A | N/A | | Set/OptimalMerkleTree::::set_range/10 | 5.5±0.08ms | N/A | N/A | | Set/OptimalMerkleTree::::set_range/100 | 54.5±1.06ms | N/A | N/A | | zkey::upload_from_folder | **3.2±0.02s** | 3.3±0.02s | **+3.12%** |