search

vacuumlabs / adalite-backend-service

Icarus, a reference implementation for a lightweight wallet developed by the IOHK Engineering Team.
Apache License 2.0
2 stars 7 forks source link

dateFrom param not working #62

Open refi93 opened 5 years ago

refi93 commented 5 years ago

moved from: https://github.com/vacuumlabs/adalite/issues/519

@roccomusso wrote:

Looks like the adalite legacy api api/v2/txs/history hasn't the dateFrom param working? I'm not able to filter returned txs by dateFrom.

Edit: I just discovered that for example if a tx has date 1568388391000, putting as dateFrom: 1568388391000 + 1 would still show the tx. But If I sum like 7 seconds, it won't show the tx (that's the wanted behavior). So the question is why do I need to add like 7000 ms?

roccomuso commented 5 years ago

Thanks. Following the thread here

roccomuso commented 4 years ago

Any news on this?

MichalPetro commented 4 years ago

Hi @roccomuso - we are currently not using this functionality on AdaLite and therefore this is on the bottom of our priority list. We are currently working on the incentivized test-net support.

As AdaLite is an open source project, feel free to debug a fix this issue and submit a PR. We will be more than happy to review and merge it.

roccomuso commented 4 years ago

With a new instance looks like it's working. https://explorer2.adalite.io is not updated pheraps?

refi93 commented 4 years ago

@roccomuso there were no recent changes regarding this endpoint or related queries, but the new backend is using a different importer.

I just checked the databases of both the old icarus-importer and the new adalite-imporer (fork of tangata-manu) and it seems that the old importer was setting the last_updated timestamp to the time when the record was added to the database by the importer itself, whereas in the new importer this attribute almost mirrors the time column (I guess they may differ if some chain reorganization happens, but that's a question rather for tangata-manu devs), so that's the likeliest explanation why you observe that it started working on the new explorer instance