vacuumlabs / adalite-backend-service

Icarus, a reference implementation for a lightweight wallet developed by the IOHK Engineering Team.
Apache License 2.0
2 stars 7 forks source link

/api/txs/last endpoint with new importer takes long #69

Closed refi93 closed 4 years ago

refi93 commented 4 years ago

Calling /api/txs/last enpoint on adalite-backend-service using the new importer (tangata-manu, more precisely adalite-importer, its fork), it takes long as there is no index on the "time" column in the txs tables created by yoroi-importer's migrations. We could either:

a) submit a PR to tangata-manu, add that index to the table and sync adalite-importer b) just drop this endpoint since it isn't really used, only for debugging, but arguably, the /bestBlock endpoint can be used as well to see how the node is syncing

I propose solution b) as it is simpler and I think that the /api/txs/last endpoint does not provide significant added value vs the /bestBlock endpoint.

refi93 commented 4 years ago

resolved by #70