vacuumlabs / adalite-backend-service

Icarus, a reference implementation for a lightweight wallet developed by the IOHK Engineering Team.
Apache License 2.0
2 stars 7 forks source link

Fix cardano-submit-api image reference to point to a stable version #90

Closed refi93 closed 4 years ago

refi93 commented 4 years ago

We've got a report from @roccomuso that the recently updated master tag of cardano-submit-api (https://hub.docker.com/layers/inputoutput/cardano-submit-api/master/images/sha256-c08361d147d47e03bf86a70289ac27d16a36a5f6bb558c529a64e0f5b9b270bc?context=explore) is breaking their infrastructure

I checked cardano-rest repo and they switched to the "latest" tag and added a config variable to override the version if needed (https://github.com/input-output-hk/cardano-rest/blob/6bd244b9277970ae9ec6000555da4ae423670950/docker-compose.yml#L81) so I'm mirroring the changes here

roccomuso commented 4 years ago

Thanks for the responsiveness :D

refi93 commented 4 years ago

I'm still checking if latest tag works as they switched to it in the cardano-rest repo: https://github.com/input-output-hk/cardano-rest/blob/6bd244b9277970ae9ec6000555da4ae423670950/docker-compose.yml#L81

ksemaev commented 4 years ago

@refi93 iohk team strongly recommends to use :latest image, as the stable ones

refi93 commented 4 years ago

@ksemaev thanks - where did you get that information from?

ksemaev commented 4 years ago

@refi93 we have a direct contact with Neville Freeman and we had a 1h call when they pushed new master image. Master is just a branch that get all the lastest code, it's not a release branch etc. Master tags shouldn't be here: https://github.com/input-output-hk/cardano-rest/blob/2.0.0/docker-compose.yml , it was stable only several weeks until they pushed new master images. Saying that - the future changes for shelley I suppose will come from master branch (since it has the lastes code), so I'm not sure if it worth downgrading to latest.

And while you're here - the latest release of indexer is https://github.com/input-output-hk/cardano-db-sync/releases/tag/2.1.0 while this image you're using is based on 2.0.0 if I'm not mistaking https://github.com/vacuumlabs/adalite-backend-service/blob/shelley-hard-fork/docker/docker-compose.yml#L59 Not sure if you can/should upgrade painlessly, I had to resync from 0 for our parallel graphql setup.

refi93 commented 4 years ago

@ksemaev Thanks for the info - for now we are freezing the images to our last known stable setup and we will be changing this very soon anyway as the hard fork to Shelley is nearing: https://github.com/vacuumlabs/adalite-backend-service/pull/89

We have our own fork of cardano-db-sync which pushes to the db also raw tx bodies which seems to be missing from the official release of db-sync but we depend on it as it's required to support hw wallets, anyway, we will be switching it soon as well due to Shelley where such feature won't be needed as the fee will be explicitly part of the transaction

ksemaev commented 4 years ago

@refi93 IOHK released a lot of updates today/yesterday: Cardano Node 1.18.0 https://github.com/input-output-hk/cardano-node/releases/tag/1.18.0 , Cardano DB Sync 3.0.0 https://github.com/input-output-hk/cardano-db-sync/releases/tag/3.0.0 (requires full resync), Cardano Rest 2.1.0 https://github.com/input-output-hk/cardano-rest/releases/tag/2.1.0 Can you please update this issue, or point to some release/branch, where we can track when you'll switch to those new versions?

refi93 commented 4 years ago

Hi @ksemaev - we are updating the backend to be compatible with Shelley here: https://github.com/vacuumlabs/adalite-backend-service/pull/89 - as of July 29 (Shelley launch date) we will likely be still running the node/db sync without docker but it should work with the latest db sync/cardano node if you set it up locally. @xdzurman can provide more insight as he's working on it - feel free to ask directly in that PR