search

vacuumlabs / name-bazaar

A peer-to-peer marketplace for the exchange of names registered via the Ethereum Name Service
Eclipse Public License 1.0
0 stars 0 forks source link

Only warn when a name cannot be resolved from public resolver #36

Closed Siegrift closed 3 years ago

Siegrift commented 3 years ago

1) Updated the ws dependency, which was breaking at development for me.

2) Warn when a name cannot be resolved from public resolver By removing :public-resolver.name/load from the arguments of the on-error callback I was able to print the stack trace of exception.

The error is Uncaught BigNumber Error: new BigNumber() not a base 16 number:, which is described in: https://ethereum.stackexchange.com/questions/1741/what-does-the-web3-bignumber-not-a-base-16-number-error-mean

and is probably a result of using old web3, which fails to convert the value of non-existent mapping to string from public resolver: https://github.com/ensdomains/resolvers/blob/339bf4376572358ae495449bba8352f3932bb0fe/contracts/profiles/NameResolver.sol#L29