May 2023

[vadasambar]

Last month's thread: Apr 2023: https://github.com/vadafoss/daily-updates/issues/8

What

This is an issue to update daily status on what I am doing as a member of vadafoss community.

How

Follow this format

## <3-letter-month> <2-letter-day> <4-letter-year>
### やったこと
### Problem
### Try
### TODO
### WIP

やったこと: yatta-koto lit. 'things I did' in Japanese (I just find it sounds closer to what I want to say) Problem (optional): problems I faced Try (optional): what I am trying TODO (optional): things to do WIP (optional): work in progress

[vadasambar]

May 02 2023

やったこと

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • tested with scheduler extender: https://github.com/kubernetes/autoscaler/pull/5708#issuecomment-1530967605

    WIP

• planning
• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • redact sensitive info and post the results of expander test as a comment

    TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • test with custom config for in-tree plugins
• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708
• look at the behavior of scheduler when it fails to reach extender and replicate it in https://github.com/kubernetes/autoscaler/pull/5708
• apply for Kubernetes community membership: https://github.com/kubernetes/community/blob/master/community-membership.md
  • brought it up in the sig-autoscaling meeting. Waiting for the community's response
  • https://docs.google.com/document/d/1RvhQAEIrVLHbyNnuaT99-6u9ZUMp7BfkPupT2LAZK7w/edit#
• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231
• https://github.com/kubernetes/autoscaler/issues/4231
  • go through the code to understand what might be happening
• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947
• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136
• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 03 2023

やったこと

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • redact sensitive info and post the results of expander test as a comment
  • done: https://github.com/kubernetes/autoscaler/pull/5708#issuecomment-1532494382

    WIP

• planning

  TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • test with custom config for in-tree plugins
• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708
• look at the behavior of scheduler when it fails to reach extender and replicate it in https://github.com/kubernetes/autoscaler/pull/5708
• apply for Kubernetes community membership: https://github.com/kubernetes/community/blob/master/community-membership.md
  • brought it up in the sig-autoscaling meeting. Waiting for the community's response
  • https://docs.google.com/document/d/1RvhQAEIrVLHbyNnuaT99-6u9ZUMp7BfkPupT2LAZK7w/edit#
• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231
• https://github.com/kubernetes/autoscaler/issues/4231
  • go through the code to understand what might be happening
• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947
• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136
• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 04 2023

やったこと

WIP

• planning

  TODO

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618
• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • test with custom config for in-tree plugins
• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708
• look at the behavior of scheduler when it fails to reach extender and replicate it in https://github.com/kubernetes/autoscaler/pull/5708
• apply for Kubernetes community membership: https://github.com/kubernetes/community/blob/master/community-membership.md
  • brought it up in the sig-autoscaling meeting. Waiting for the community's response
  • https://docs.google.com/document/d/1RvhQAEIrVLHbyNnuaT99-6u9ZUMp7BfkPupT2LAZK7w/edit#
• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231
• https://github.com/kubernetes/autoscaler/issues/4231
  • go through the code to understand what might be happening
• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947
• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136
• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 05 2023

やったこと

• start a draft PR to fix https://github.com/kubernetes/autoscaler/issues/3071
  • https://github.com/kubernetes/autoscaler/pull/5729
• tweeted about AUTOSCALER_ENV_VARS support for GCE provider in cluster-autoscaler: https://twitter.com/_vadasambar/status/1654369700737077249
• created an issue to add README for gce provider in cluster-autoscaler: https://github.com/kubernetes/autoscaler/issues/5730

WIP

• planning

  TODO

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618
• [DEADLINE: 8th May before SIG meeting] come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • test with custom config for in-tree plugins
  • add a comment in the PR
• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708
• look at the behavior of scheduler when it fails to reach extender and replicate it in https://github.com/kubernetes/autoscaler/pull/5708
• apply for Kubernetes community membership: https://github.com/kubernetes/community/blob/master/community-membership.md
  • brought it up in the sig-autoscaling meeting. Waiting for the community's response
  • https://docs.google.com/document/d/1RvhQAEIrVLHbyNnuaT99-6u9ZUMp7BfkPupT2LAZK7w/edit#
• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231
• https://github.com/kubernetes/autoscaler/issues/4231
  • go through the code to understand what might be happening
• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947
• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136
• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 08 2023

やったこと

• check out review comments for https://github.com/kubernetes/autoscaler/pull/5708
  • replied to the comments
• check out review comments for https://github.com/kubernetes/autoscaler/pull/5729
  • replied to the comments
• address review comments for https://github.com/kubernetes/autoscaler/pull/5729
  • addressed most of them
  • added code to update scale up time per nodegroup
  • moved struct to track scale up times to clusterstate
  • code: https://github.com/kubernetes/autoscaler/pull/5729/commits/e90529bae270d61f345bc01b71722295d5a469ac

    WIP

TODO

• create issue for becoming member of Kubernetes org
• address review comments for https://github.com/kubernetes/autoscaler/pull/5729
• get an OK for proceeding ahead on https://github.com/kubernetes/autoscaler/pull/5708 from the community
• address review comments for https://github.com/kubernetes/autoscaler/pull/5708
• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618
• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708
  • test with custom config for in-tree plugins
  • add a comment in the PR
• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708
• look at the behavior of scheduler when it fails to reach extender and replicate it in https://github.com/kubernetes/autoscaler/pull/5708
• apply for Kubernetes community membership: https://github.com/kubernetes/community/blob/master/community-membership.md
  • brought it up in the sig-autoscaling meeting. Waiting for the community's response
  • https://docs.google.com/document/d/1RvhQAEIrVLHbyNnuaT99-6u9ZUMp7BfkPupT2LAZK7w/edit#
• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231
• https://github.com/kubernetes/autoscaler/issues/4231
  • go through the code to understand what might be happening
• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947
• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136
• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 09 2023

やったこと

• get an OK for proceeding ahead on https://github.com/kubernetes/autoscaler/pull/5708 from the community
  • had a discussion around this in the SIG meeting yesterday
  • there are performance concerns around running an external scheduler extender
• apply for Kubernetes community membership: https://github.com/kubernetes/community/blob/master/community-membership.md
  • brought it up in the sig-autoscaling meeting. Waiting for the community's response
  • https://docs.google.com/document/d/1RvhQAEIrVLHbyNnuaT99-6u9ZUMp7BfkPupT2LAZK7w/edit#
  • 
  • got a go-ahead from the community (Guy and Elmiko are sponsoring me)
  • created issue: https://github.com/kubernetes/org/issues/4203
  • added it to the SIG agenda doc so that I don't forget to follow up with Guy and elmiko
  • 
• check Maciek's comment on https://github.com/kubernetes/autoscaler/pull/5708#issuecomment-1538647324
  • replied: https://github.com/kubernetes/autoscaler/pull/5708#issuecomment-1539546973

WIP

• use clusterstate to figure out per node scale down in https://github.com/kubernetes/autoscaler/pull/5729

  TODO

• address review comments for https://github.com/kubernetes/autoscaler/pull/5729

• address review comments for https://github.com/kubernetes/autoscaler/pull/5708

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 10 2023

やったこと

• address review comments for https://github.com/kubernetes/autoscaler/pull/5708
  • remove code related to scheduler extenders: https://github.com/kubernetes/autoscaler/pull/5708/commits/fade953f03acf619235eed7f981ae4f27af37d50
  • moved code to generate/load scheduler config to a separate package: https://github.com/kubernetes/autoscaler/pull/5708/commits/d58399d0576599d0add15d0de36ee0155470f6d3
• address review comments for https://github.com/kubernetes/autoscaler/pull/5729
  • DONE
• use clusterstate to figure out per node scale down in https://github.com/kubernetes/autoscaler/pull/5729
  • https://github.com/kubernetes/autoscaler/pull/5729/commits/b9f3ea5adf1c751cfd169032cda9311f0d32dbdc
  • https://github.com/kubernetes/autoscaler/pull/5729/commits/40def637e4735462a0da1f788eacf0f53370bc5c
  • https://github.com/kubernetes/autoscaler/pull/5729/commits/8fb1418b6a40c99dd72f2fa9849b5961dec47993
  • https://github.com/kubernetes/autoscaler/pull/5729/commits/48da4edfca5e5b8a8c09a39be172a1d5568049ea

    WIP

TODO

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 11 2023

やったこと

• started a thread in #sig-scheduling asking if the community is interested in supporting GRPC for scheduler extenders

  • https://kubernetes.slack.com/archives/C09TP78DV/p1683784989107089

• fix clusterstate tests failing in https://github.com/kubernetes/autoscaler/pull/5729

  • fixed: https://github.com/kubernetes/autoscaler/pull/5729/commits/74706bcb509489c21bfeaf07544f42da95d93095

• fix static_autoscaler tests failing in https://github.com/kubernetes/autoscaler/pull/5708

  • fixed: https://github.com/kubernetes/autoscaler/pull/5708/commits/0cd24126dd587233ca986ce1b1e99984f7d33fe2

    WIP

• looking at supporting GRPC for scheduler extenders https://github.com/kubernetes/kubernetes/issues/60697

  • it seems like the community is leaning more towards re-compiling the scheduler approach instead of supporting GRPC for extenders.

    TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 12 2023

やったこと

• looking at supporting GRPC for scheduler extenders https://github.com/kubernetes/kubernetes/issues/60697

  • it seems like the community is leaning more towards re-compiling the scheduler approach instead of supporting GRPC for extenders.
  • extenders is not in active development except for bug fixes: https://kubernetes.slack.com/archives/C09TP78DV/p1683784989107089

• look at new review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842

  • replied

• look at new review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1191103299

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • replied

    WIP

• working on a blogpost

  TODO

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1191103299

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 15 2023

やったこと

• add items to sig-autoscaling agenda
  • DONE:

WIP

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842

  TODO

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1191103299

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 16 2023

やったこと

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842

  • refactor: GetSchedulerConfiguration fn
  • test: wip add tests for GetSchedulerConfig

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1191103299

  • added a comment https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1194654196

    WIP

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1191103299

  TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 17 2023

やったこと

• address review comments by Daniel and make the PR ready for review in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842
  • test: add tests for GetSchedulerConfig
  • refactor: do a round of cleanup to make PR ready for review
  • fix: use pflag to check if the --scheduler-config-file flag was set
  • docs: add comments for exported error constants
  • refactor: don't export error messages
  • fix: add underscore in test file name
  • test: fix test failing because of no comment on exported `SchedulerCo…
  • refacotr: change name of flag variable schedulerConfig -> `schedule…
  • test: add extra test cases for predicate checker
  • refactor: remove setFlags variable

    WIP

• address review comments by Daniel and make the PR ready for review in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842

TODO

• • address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1191103299

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 18 2023

やったこと

• address review comments by Daniel and make the PR ready for review in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1422416842

  • PR is ready for review: https://github.com/kubernetes/autoscaler/pull/5708#issuecomment-1552383760

• cleaned up code for schedconfig and pushed it

  • refactor: clean up code

• address review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1191103299

  • replied: https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1194654196
  • waiting for Daniel's reply

    WIP

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

    TODO

• [DEADLINE: MON 22ND MAY] cherry-pick my PRs to 1.24 to 1.27 https://kubernetes.slack.com/archives/C09R1LV8S/p1684415226611399

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 19 2023

やったこと

• tweeted about DaemonSet target blocking PDB completely: https://twitter.com/_vadasambar/status/1659417271679479814

  WIP

• working on a blogpost

  TODO

• look at https://github.com/kubernetes/autoscaler/issues/5769

• reply to comment asking to support * for ignoring local storage volumes in CA:

  • https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1553931978
  • https://github.com/kubernetes/autoscaler/pull/5594#issuecomment-1553930908

• address new review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1432663230

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 22 2023

やったこと

• decide cherry-picks to 1.24~1.27 and cherry-pick the PRs

  • check the slack thread: https://kubernetes.slack.com/archives/C09R1LV8S/p1684415226611399
  • done: https://github.com/kubernetes/autoscaler/issues/5774#issuecomment-1556514840

• check responses around slack thread asking how to import a minikube cluster into cluster-api in #cluster-api slack channel

  • slack thread: https://kubernetes.slack.com/archives/C8TSNPY4T/p1684475295769019
  • responded (there's a PoC stage solution which might solve my problem: https://github.com/tobiasgiese/cluster-api- migration
  • look at how to test for bottleneck for https://github.com/kubernetes/autoscaler/issues/5769 (using kubemark?)

• reply to comment asking to support * for ignoring local storage volumes in CA:

  • https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1553931978
    • replied:
    • https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556577363
    • https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556579390
    • https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564
  • https://github.com/kubernetes/autoscaler/pull/5594#issuecomment-1553930908
  • https://github.com/kubernetes/autoscaler/pull/5594#issuecomment-1556576760

• look at https://github.com/kubernetes/autoscaler/issues/5769

  • https://github.com/kubernetes/autoscaler/issues/5769#issuecomment-1556567140

• address new review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1432663230

  • replied to the comments

    WIP

    TODO

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• address new review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1432663230

  • make changes to address the review comments

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 23 2023

Stopped early due to some personal work.

やったこと

• address new review comments by Daniel in https://github.com/kubernetes/autoscaler/pull/5708#pullrequestreview-1432663230

  • make changes to address the review comments
    • refactor: abstract custom scheduler configs into conifg package
    • test: fix linting error
    • refactor: introduce a new custom test predicate checker
    • refactor: rename NewCustomPredicateChecker -> `NewTestPredicateChec…

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5708

  • test with custom config for in-tree plugins
  • add a comment in the PR

• check if validating the config is really required for https://github.com/kubernetes/autoscaler/pull/5708

  • it is required

    WIP

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

    TODO

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/5790

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 24 2023

やったこと

• review https://github.com/kubernetes/autoscaler/pull/5799

  • mwielgus already reviewed and merged it

• check review comment by qianlei90 on https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1203384702

  • replied to the review comment: https://github.com/kubernetes/autoscaler/pull/5729/files#r1203436718

    WIP

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

    TODO

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/5790

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 25 2023

やったこと

• check qianlei90's comment in https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1204958500

  • responded: https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1204980722

• answer why we need CA bundle for aws provider for cluster-autoscaler https://kubernetes.slack.com/archives/C09R1LV8S/p1684860923142329

  • answered: https://kubernetes.slack.com/archives/C09R1LV8S/p1684991280238379?thread_ts=1684860923.142329&cid=C09R1LV8S

• answer if using PDBs replace safe-to-evict annotation https://kubernetes.slack.com/archives/C09R1LV8S/p1684858670488589

  • answered: https://github.com/knative/serving/issues/13984#issuecomment-1562293289

    WIP

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

    TODO

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/5790

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 26 2023

やったこと

WIP

• working on a blogpost

TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/5790

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 29 2023

やったこと

WIP

• check out new comment by Daniel on https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1206803761

  • added a comment to confirm my understanding: https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1208975605

• planning

  TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/5790

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 30 2023

やったこと

• check https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1209370685

  • replied: https://github.com/kubernetes/autoscaler/pull/5729#discussion_r1209370685

    WIP

• look for possible ways to confirm the issue in https://github.com/kubernetes/autoscaler/issues/5769

  • implementing kwok provider: https://github.com/kubernetes/autoscaler/pull/5820

• change approach for https://github.com/kubernetes/autoscaler/pull/5729 based on Daniel's comment here

  TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/5790

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban

[vadasambar]

May 31 2023

やったこと

• look for possible ways to confirm the issue in https://github.com/kubernetes/autoscaler/issues/5769

  • implementing kwok provider: https://github.com/kubernetes/autoscaler/pull/5820
  • feat: add builder for kwok
  • feat: wip parse node templates from file

• create a PoC to parse node templates from file

  • done: https://github.com/vadafoss/node-templates

• change approach for https://github.com/kubernetes/autoscaler/pull/5729 based on Daniel's comment here

  • refactor: move back initializing processors logic to from static auto…

    WIP

• look for possible ways to confirm the issue in https://github.com/kubernetes/autoscaler/issues/5769

  • implementing kwok provider: https://github.com/kubernetes/autoscaler/pull/5820

• change approach for https://github.com/kubernetes/autoscaler/pull/5729 based on Daniel's comment here

  • refactor: move back initializing processors logic to from static auto…

    TODO

• come up with a way to test https://github.com/kubernetes/autoscaler/pull/5729

  • manually
  • in code

• create a follow-up ticket to enhance ignore-vol annotation in CA: https://github.com/kubernetes/autoscaler/issues/3947#issuecomment-1556582564

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/5790

• check out new comments in https://github.com/kubernetes/autoscaler/issues/5618

• respond to new comment in https://github.com/kubernetes/autoscaler/issues/4231

• https://github.com/kubernetes/autoscaler/issues/4231

  • go through the code to understand what might be happening

• check https://github.com/kubernetes/autoscaler/issues/5566#event-8829893947

• check comment https://github.com/kubernetes/autoscaler/issues/5377#issuecomment-1480601136

• check the Kanban

Problem

• check the Kanban