vadasg / githubarchive-parser

10 stars 3 forks source link

Wrap graph.shutdown() in finally. #5

Closed okram closed 11 years ago

okram commented 12 years ago

wrap graph.shutdown() in a finally block.

try {
   // looping through files
} finally {
  graph.shutdown();
}

this way the batch loading is all shut down cleanly. Question: Do you need to shutdown at the bgraph level? (BatchGraph is new to Blueprints and I haven't studied it).

vadasg commented 11 years ago

I've fixed this in the code. There is indeed a BatchGraph.shutdown() method that should also be used. I've added bgraph.shutdown() to the finally{} block also.