vadikom / smartmenus

Advanced jQuery website menu plugin. Mobile first, responsive and accessible list-based website menus that work on all devices.
http://www.smartmenus.org
MIT License
592 stars 163 forks source link

Unable to open a link on sub-menu on touch device #52

Closed elonart closed 7 years ago

elonart commented 8 years ago

Hello, Because of unable to use mouse hover on touch device, I set smartmenus like this. $(‘.sm’).smartmenus({ noMouseOver : true, //disable mouse hover. showFunction : function($ul, complete) { $ul.slideDown(250, complete); }, hideFunction : function($ul, complete) { $ul.slideUp(250, complete); } }); And I use double click event to open link on sub-menu. It works fine on chrome, but not on IE and Siri. Please help me to solve this bug.

vadikom commented 8 years ago

Please post some kind of online demo (e.g. create one on https://jsfiddle.net/) so that I could test your code.

And in the future please post similar support questions in the forums http://www.smartmenus.org/forums/ . We prefer to use the Github issue tracker just for bugs in the core script functionality.

Thanks!

elonart commented 8 years ago

Dear Vasil

I posted demo to this link. Please help me to solve the issue.

https://jsfiddle.net/elonart/6z365jr8/

Edit fiddle - JSFiddlehttps://jsfiddle.net/elonart/6z365jr8/ jsfiddle.net Test your JavaScript, CSS, HTML or CoffeeScript online with JSFiddle code editor.

Dang Quang Hieu


From: Vasil Dinkov notifications@github.com Sent: Wednesday, September 28, 2016 6:48 PM To: vadikom/smartmenus Cc: elonart; Author Subject: Re: [vadikom/smartmenus] Unable to open a link on sub-menu on touch device (#52)

Please post some kind of online demo (e.g. create one on https://jsfiddle.net/) so that I could test your code.

Create a new fiddle - JSFiddlehttps://jsfiddle.net/ jsfiddle.net Test your JavaScript, CSS, HTML or CoffeeScript online with JSFiddle code editor.

And in the future please post similar support questions in the forums http://www.smartmenus.org/forums/ . We prefer to use the Github issue tracker just for bugs in the core script functionality.

SmartMenus jQuery Website Menu Plugin » Forumshttp://www.smartmenus.org/forums/ www.smartmenus.org You will receive emails only on new version releases or really important news. Your email will not be shared with anyone. We hate spam too! ©

Thanks!

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/vadikom/smartmenus/issues/52#issuecomment-250144741, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVOSAwWj01TAIZIMigy21l3hafhRZtHtks5qulQQgaJpZM4J_jIC.

elonart commented 8 years ago

Sorry, the correct link is https://jsfiddle.net/elonart/6z365jr8/2/

vadikom commented 8 years ago

Thanks, I took a look. I still don't understand what exactly is not working for you in IE (which IE version?) and Siri (how do you test in Siri?)? Please try to explain step by step what you are doing and expect to happen.

But I get the feeling you have misunderstood how the script works so a quick note - you don't need to use specifically "noMouseOver : true" on small screens - the script will automatically detect touch input and act accordingly. This option is provided just in case someone wants to mimic touch screen device behavior even in desktop non-touch mode.

elonart commented 8 years ago

Dear Vasil,

It's not working for IE11 and Safari (not Siri. Sorry). I test on smartphone. I explain my expect.

  1. For devices which support hover (Ex: PC): When hover on menu's element, it'll expand submenu. When click on menu's element, it'll open the url (href) of that element.
  2. For devices which not support hover (Ex: smartphone): When click on menu's element, it'll expand submenu. When double click on menu's element, it'll open the url (href) of that element.

Please help me to solve my expect. Best regards,

vadikom commented 8 years ago

Sorry, but I still don't get it - the way you describe it, is exactly the way the script currently works by default. Please test this page on desktop/mobile and let me know what exactly you don't like:

http://vadikom.github.io/smartmenus/src/demo/