vadimcn / codelldb

A native debugger extension for VSCode based on LLDB
https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb
MIT License
2.42k stars 237 forks source link

terminal.external.osxExec not being honored when using externalConsole: true #1003

Closed sackboy19 closed 9 months ago

sackboy19 commented 9 months ago

OS: macOS Sonoma 14.0 VSCode version: 1.82.2 CodeLLDB version: v1.10.0 Compiler: clang Debuggee: C++ binary Target triple: aarch64-apple-darwin

When starting the debugger using the externalConsole: true option, it opens the wrong terminal and doesn't respect the one set in the vscode settings. For example, if I run "Open New External Terminal" in the command palette, it will open Warp.app instead of the default Terminal.app because I set terminal.external.osxExec to "Warp.app". However, when starting a debug session with codelldb, it opens Terminal.app instead of the terminal set in terminal.external.osxExec

settings.json:

"terminal.explorerKind": "external",
"terminal.external.osxExec": "Warp.app",
"lldb.launch.terminal": "external",

launch.json:

{
  // Use IntelliSense to learn about possible attributes.
  // Hover to view descriptions of existing attributes.
  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
  "version": "0.2.0",
  "configurations": [
    {
      "name": "(lldb) Launch",
      "type": "cppdbg",
      "request": "launch",
      "targetArchitecture": "arm64",
      "program": "${workspaceFolder}/assembler_cpp_rewrite/build/debug/assembler",
      "args": ["../../../assembler/tests/math_test.s"],
      "stopAtEntry": false,
      "cwd": "${workspaceFolder}/assembler_cpp_rewrite/build/debug",
      "environment": [],
      "externalConsole": true,
      "MIMode": "lldb",
    }
  ]
}
vadimcn commented 9 months ago

"type": "cppdbg",

You are not using codelldb...