vadimcn / codelldb

A native debugger extension for VSCode based on LLDB
https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb
MIT License
2.43k stars 237 forks source link

Invalid watch for base class fields #979

Open tristanlabelle opened 11 months ago

tristanlabelle commented 11 months ago

OS: Windows 11 22H2 VSCode version: 1.18.1 CodeLLDB version: v1.9.2 Compiler: clang++ Debuggee: x86_64-windows / dwarf, both C++ and Swift LLDB version: From the Swift toolchain

lldb version 16.0.0
compnerd.org Swift version 5.9-dev (LLVM c8ca153def6029d, Swift 1381d9a7b2555c6)

When adding a watch for a data member/field of a base class, the resulting watch is broken because it uses a member access syntax that is invalid.

The problem seems to be that the code around compose_eval_name does not handle this case and produces a dot-delimited evaluationName that is incorrect.

bad watch bad watch cpp