vadimdemedes / mongorito

🍹 MongoDB ODM for Node.js apps based on Redux
1.38k stars 90 forks source link

Chore/update mongodb package #206

Open adieuadieu opened 6 years ago

adieuadieu commented 6 years ago

Updates the mongodb npm package to it's latest version.

Some small changes were made to Mongorito's code. Specifically:

While none of the Mongorito APIs or methods have changes, the update to mongobd@3 package may result in breaking changes if someone used Mongorito with use of private/undocumented Mongorito properties (e.g. mongorito's database._connection property). Therefore might make sense to release this (in conjunction with #205) as a major version release, just in case.

/cc @vadimdemedes 😄

jamescorbett commented 5 years ago

This pull request is great, and I agree with the major version change. I was using the undocumented _connection for example.

Please can you bump the version further to "mongodb": "^3.1.2" because of a bug in mongodb's driver. See https://github.com/meteor/meteor/issues/9944#issuecomment-420542042 for detail, although it's regarding Meteor, I've run into the same issue on Mongorito.