vadimkorr / svelte-carousel

The awesome carousel component for Svelte 3 :arrow_left: :art: :arrow_right:
https://vadimkorr.github.io/svelte-carousel
Apache License 2.0
279 stars 56 forks source link

Missing Exports Condition Warning in Sveltekit #161

Open fractalmandala opened 3 months ago

fractalmandala commented 3 months ago

Using this library in Sveltekit is showing a missing exports condition warning:

The following packages have a svelte field in their package.json but no exports condition for svelte.
svelte-carousel@1.0.25
Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.

At the link:

If you see a warning logged for this when using a Svelte library, please tell the library maintainers.

Using the svelte field in package.json to point at .svelte source files is deprecated and you must use a svelte export condition. vite-plugin-svelte 3 still resolves it as a fallback, but in a future major release this is going to be removed and without exports condition resolving the library is going to fail.

Example:

// package.json
  "files": ["dist"],
  "svelte": "dist/index.js",
+ "exports": {
+   ".": {
+     "svelte": "./dist/index.js"
+   }
  }
darkwiz666 commented 2 months ago

https://github.com/vadimkorr/svelte-carousel/pull/158

Looks like it's waiting to be merged or whatever.


And it's not likely to be done any time soon, so if you can, best to fork it and manage it yourself.

jalamprea commented 2 months ago

It looks like the PR was deleted for no reason :( This should be pretty important because this package will not be able to continue working on future versions of vite