search

vadimostanin / opennero

Automatically exported from code.google.com/p/opennero
Other
0 stars 0 forks source link

Code review request #38

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:
trunk

When reviewing my code changes, please focus on:
r526: Ideally this should, if wx is not installed, call up a wiki page ('wx'), 
and then return to hub, testing on a local machine with a non-existant package 
replacing wx (skynet) does not result in appropriate behavior, but also does 
not interfere with behavior. Any reason these functions aren't working properly 
at that location?

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by AdamDz...@gmail.com on 20 Sep 2010 at 3:54

GoogleCodeExporter commented 9 years ago 
There are two different problems here:

  1. openWiki('WikiPage') returns a function (closure) so that you can use it to assign an action for the GUI. So in order to actually perform the action you have to call it, e.g. openWiki('WikiPage')(). Note that for some reason python2.6 on CS hosts does not have a working webbrowser.open configured - while it is possible to configure it, this is clearly not our fault and most python setups will have it working by default with the default browser on the user's platform.

  2. switchMod() only makes a request to switch the mod - the mod is actually switched on the next frame. I changed the source of Kernel.cpp so that if the request is made during the switch from another mod, it doesn't get ignored (the request flag was getting reset after the python code for the new mod was executed).

Original comment by ikarpov on 20 Sep 2010 at 4:03

GoogleCodeExporter commented 9 years ago 
Revision #527 should address both issues.

Original comment by ikarpov on 20 Sep 2010 at 4:06