vadimpopa / ionic2-jspm-seed

ionic2-jspm-seed and plus a typescript starter
MIT License
9 stars 5 forks source link

Updated typescript & systemjs config #1

Closed frankwallis closed 8 years ago

frankwallis commented 8 years ago

I have got the app running, and I have tried to bring it a bit more in line with what I think is a recommended setup. I made the following changes:

1) Stopped using _references.d.ts and moved the file list into tsconfig.json, I think this is the current best practice for typescript projects. 2) Moved the ionic map configuration inside the package configuration in system.config.js. The problem with it being where it was is that it would get overwritten by jspm when you update dependencies etc. 3) I fixed a bug in plugin-typescript (thanks!) and upped the version to 2.1.6 4) Upped the ionic version to alpha.31 5) Switched to using the es5 commonjs output instead of typescript - I am getting a runtime error when using the typescript directly. Ideally I think consumers should use the ionic bundle but I have not found a way to do that yet. 6) Added a simple declaration of 'ionic/ionic' - this definition would normally come by installing the ionic declaration file using the 'tsd' tool. The resolveAmbientDeclarations stuff is probably going to get deprecated soon, so I would advise using tsd instead.

You are welcome to accept this PR or make your own changes, I don't mind. It has been useful for me to see what configuration was needed and I found a bug in the plugin in the process. If you want any more info then let me know, thanks.

vadimpopa commented 8 years ago

@frankwallis thank you for your try and fixes, much appreciated to get it running. 2) Yes I know, for now, for me was enough to start the app, then improve the rest. I'm still learning everything around SystemJS and jspm, thanks for your clarifications. 5) Yes I got that run-time bug also at Toolbar extended by NavBar, will report it to Ionic issues page.