search

vadimpronin / guacamole-lite

Node.js library for creating Guacamole-compatible servers. Guacamole is a RDP/VNC/SSH/Telnet client for HTML5 browsers.
Apache License 2.0
250 stars 78 forks source link

Potential issue in process exiting #10

Open wperrigo opened 7 years ago

wperrigo commented 7 years ago

When the node process is aborted (ctrl+c) it hangs permanently at Closing all connections and exiting...

To fix I added process.exit() to the close method. Is this a known issue?

vadimpronin commented 7 years ago

Yes, I've noticed it myself a few days ago. Indeed process.exit() needs to added, but first the code needs some refactoring as the method close() is async and just adding process.exit() to the end of it will break all async processes going on. I'll do this refactoring and release the new version next week.

dormeiri commented 6 months ago

I also encountered it, raised a PR with a fix in https://github.com/vadimpronin/guacamole-lite/pull/58